Add test for `rename_all` on enum struct variants

Aleph-Alpha / ts-rs

Generate TypeScript bindings from Rust types

MIT License

1.15k stars 115 forks source link

Add test for `rename_all` on enum struct variants #197

Closed escritorio-gustavo closed 10 months ago

escritorio-gustavo commented 10 months ago

Added test requested in this thread: https://github.com/Aleph-Alpha/ts-rs/issues/135#issuecomment-1902162740

Fixed version of #196

escritorio-gustavo commented 10 months ago

I seem to be really bad at making these PRs the first one included wrong code and this seems to include nothing at all smh

NyxCode commented 10 months ago

😄 All good, thanks for the PR! I really like that we are accumulating loads of test. Really helps with making changes when there's confidence that we didnt break anything important.

escritorio-gustavo commented 10 months ago

Yeah, I was kind of scared of making the #199 PR until I ran cargo test and nothing failed xD

NyxCode commented 10 months ago

At least I really have to rely on the test suite at this point. No way I can look at a piece of code and understand all of its implications.