search

Aleqsd / abwriting

MIT License
0 stars 0 forks source link

Bump foo-software/lighthouse-check-action from 4.0.0 to 7.1.0 #28

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 2 years ago

Bumps foo-software/lighthouse-check-action from 4.0.0 to 7.1.0.

Release notes

Sourced from foo-software/lighthouse-check-action's releases.

Default config update

Summary

Default configurations were updated in Lighthouse 8. We should have made this change when Lighthouse 8 was introduced, hence this is considered a fix. This change could have an impact on scores, namely desktop, which is why we released this as a minor version bump instead of a patch.

PRs

Node 16 Runner

Summary

Converts this GitHub Action back to being Node.js based with the Node16 runner.

History

The reason this project was converted to Docker in the first place was because of the lack of traction this issue was getting: actions/runner#772

It became doubtful that any Node runner above Node 12 would be provided, based on how long ago Node 14 became the LTS. Lighthouse 9 requires a Node version of 14 or higher, and so the choice was made to convert this GitHub Action to Docker based. Of course, within a week or so after that - the Node16 runner was created and made available by GitHub... paving the way for this MR.

Minor Docker Image Update to Support Artifacts

Summary

Minor Docker image update. Also, updated our examples to show how to upload artifacts.

Lighthouse 9 + use Docker runner instead of Node runner

Summary

Bumps @foo-software/lighthouse-check to version 5 and effectively Lighthouse 9. Because Lighthouse 9 enforces a minimum of Node 14 and GitHub still has not published a Node 14 GitHub Action runner we use a Docker runner instead of Node. This also remedies the issue of needing to keep the dist and node_modules directories versioned in this project.

Breaking Changes

Because this GitHub Action now runs within a Docker containerized environment vs directly in the GitHub Action runner via Node, when persisting artifacts for example, such as reports the following change would be required.

name: Lighthouse Check
on: [pull_request]

jobs:
lighthouse:
# ...
steps:
# ...


    

  • 

     - run: mkdir -p /tmp/artifacts

    

    • 



    

  • 

     - run: mkdir -p ${{ github.workspace }}/tmp/artifacts
- name: Run Lighthouse
  uses: ./
  with:

    

    • 



</tr></table>

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 2 years ago

The following labels could not be found: dependencies, automerge.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for abwriting ready!

🔨 Explore the source changes: 21824a0c35f8262fbdc7a644e06a510009d603c8

🔍 Inspect the deploy log: https://app.netlify.com/sites/abwriting/deploys/61a99b767db56000079fb223

😎 Browse the preview: https://deploy-preview-28--abwriting.netlify.app

dependabot[bot] commented 2 years ago

Superseded by #33.