search

Aleqsd / abwriting

MIT License
0 stars 0 forks source link

Bump foo-software/lighthouse-check-action from 4.0.0 to 9.0.0 #76

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 2 years ago

Bumps foo-software/lighthouse-check-action from 4.0.0 to 9.0.0.

Release notes

Sourced from foo-software/lighthouse-check-action's releases.

Fast fail when runtime errors occur

Summary

In light of #99 this GitHub Action will now fail a job when Lighthouse results in a runtime error (only applies to "local" Lighthouse runs). This GitHub Action allows for multiple Lighthouse audits within a single job, so if any encounter a runtime error - it will "fast fail" the entire job. maxRetries input will cover these errors and retry if set.

There is an argument to not fast fail the job when these types of errors occur as one may want to preserve runs of other Lighthouse audits within the job, however this would lead to complications in downstream behavior and could cause silent, ignored issues that may eventually become tricky to pinpoint. If a Lighthouse audit is failing with runtime errors, something is wrong that should be addressed, hence another justification of failing the job.

Because this release changes the way errors are handled it is considered a major change in terms of versioning.

Surface Lighthouse runtime errors

Summary

Catches and surfaces runtimeError from Lighthouse result for more verbose output in the logs, comments and Slack messages.

Related

Minor logging and PR comment updates

No release notes provided.

Improved output to support partial results

Summary

Bumps @foo-software/lighthouse-check to only output results when they exist. For example with 'onlyCategories': ['performance']' we should only output performance scores.

Issues

Upstream

Breaking Change Notes

This is considered a "breaking change" only because it changes the output. Previously scores for categories that were not present would be represented with 0 numbers and now they are excluded altogether. It's unlikely you are relying on this.

Updates node_modules with Node 16

This change was done just for good measure. No issues were found as it was.

Default config update

Summary

Default configurations were updated in Lighthouse 8. We should have made this change when Lighthouse 8 was introduced, hence this is considered a fix. This change could have an impact on scores, namely desktop, which is why we released this as a minor version bump instead of a patch.

PRs

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 2 years ago

The following labels could not be found: dependencies, automerge.

netlify[bot] commented 2 years ago

Deploy Preview for abwriting ready!

Name Link
Latest commit 96625651d3f358a5503183fa2fb33a3d8b359247
Latest deploy log https://app.netlify.com/sites/abwriting/deploys/62d0eb6e918b8f00098a7f72
Deploy Preview https://deploy-preview-76--abwriting.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dependabot[bot] commented 1 year ago

Superseded by #106.