search

AleshaOleg / holy-grail-markup

All CSS methodologies compared examples at one place.
https://aleshaoleg.github.io/holy-grail-markup/raw
223 stars 41 forks source link

Increase the size of the html file (page) #37

Open thierryk opened 7 years ago

thierryk commented 7 years ago

I like this project very much but I think the results are biased due to the (very small) size of the document being used (index.html). In my opinion, the results would be more relevant if the example page was closer to the size of a average page on the web (in term of components, not just raw text or images).

AleshaOleg commented 7 years ago

Hey, thanks for an issue. Do you mean to add, more images/text? Or add, for example, block for advertisement/video?

Now I don't see any need to add more things to the page. Content it's not important there:) Why do you want to add more content in pages?

idmytro commented 7 years ago

More different components with more different css classes and rules. Atomic CSS shines better if we use it for larger examples.

My personal opinion: one html page can't show full power of Atomic CSS in numbers. It is nice to have a simple Atomic CSS example here.

ihorzenich commented 7 years ago

Thank you for issue, @thierryk! You right, it will be cool to add more regular components to page as used on today's sites.

But you should understood, it will need some time to work on it for us.

@AleshaOleg, I think it not about content, but about layout/markup for regular components like these: https://ui8.s3.amazonaws.com/uploads/retina_ux-kits-wireframes-4_1439501210139.png

thierryk commented 7 years ago

@AleshaOleg: as @idmytro and @ihorzenich say, it is not about content but about the number of components in the page as this relates directly to the number of rules necessary to style that document.

Like I said, I like your project a lot, it is just that I don't think the data is meaningful yet because of the sample you're using.

@ihorzenich: yes, I realize that you won't be able to make that change anytime soon, but I'm glad you understand how important it is for the sample to be more representative of real life examples.