AleshaOleg / holy-grail-markup

All CSS methodologies compared examples at one place.
https://aleshaoleg.github.io/holy-grail-markup/raw
223 stars 41 forks source link

Add link to "BEM SASS" for 'bem-platform' metodology #48

Closed SenDen1 closed 6 years ago

SenDen1 commented 6 years ago

When I implemented 'bem-sass' methodology, I added links to it for all other methodologies at sidebar, except 'bem-platform'. Looks like to implement changes it has to be built. And I'm not sure I would make it correctly. I guess there should be added an object similar to the one for css:

{
    url: 'https://aleshaoleg.github.io/holy-grail-markup/bem-css/',
    content: 'BEM CSS'
},

And command 'node build' run.

SenDen1 commented 6 years ago

@tadatuta could you confirm my guesses please, or let me know if I'm mistaken.

tadatuta commented 6 years ago

@SenDen1 yes, looks reasonable

SenDen1 commented 6 years ago

@AleshaOleg @ihorzenich Created PR for fixing this issue: https://github.com/AleshaOleg/holy-grail-markup/pull/50

ihorzenich commented 6 years ago

@SenDen1 merged, thanks!