search

Alessandro100 / concordia-campus-guide

React project that allows navigation of concordia campuses
GNU General Public License v3.0
1 stars 0 forks source link

Feature/#97 refactor show directions to match class diagram #103

Closed Alessandro100 closed 4 years ago

Alessandro100 commented 4 years ago

In this pull request I refactored the ShowDirection component to match the class diagram. I added tests to cover the new classes that were created. All functionality remains the same

Alessandro100 commented 4 years ago

As we wont be dealing be dealing with 'arrival time' and 'departure time' I figure it be best to keep that value as an enum instead of a class since its only value will be to return a string.

As for the googlaMapsAdapter, I changed the name of the method to match the class diagram, but we will need to add more methods in the class diagram to match the implementation or else the calculatePath method will be too large

n-sheikh commented 4 years ago

Lets discuss transport representation at a later date. Please add methods to class diagram as soon as you can.