search

Alessandro100 / concordia-campus-guide

React project that allows navigation of concordia campuses
GNU General Public License v3.0
1 stars 0 forks source link

Feature/#146 As a user I want to see the concordia shuttle schedule #167

Closed Landry333 closed 4 years ago

Landry333 commented 4 years ago

Implementing feature for the shuttle schedule display

Kresten24 commented 4 years ago

There is so much wrong with this PR I can't even list it all, but Ill list the main points.

  • There are 43 files changed for a small section meaning that you must of branched off the wrong branch when writing this and it thinks this is new code when its not. Since I don't know what code is yours or others I cannot review this
  • The feature branch name is too long and contains irrelevant information
  • The commit messages make no sense

Recommendation:

  • Create a new branch by branching off staging, and write your code there with proper commit messages and a proper branch name

Upon investigation, it seems like many of the changes are just whitespace. There was some small mistake in the way git was used, but you can remove whitespace changes on github when analysing the files that changed. I'm not quite sure what caused all the whitespace changes.