Alessandro100 / concordia-campus-guide

React project that allows navigation of concordia campuses
GNU General Public License v3.0
1 stars 0 forks source link

Feature/#143 nav concordia menu #170

Closed marwan-ayadi closed 4 years ago

marwan-ayadi commented 4 years ago
Alessandro100 commented 4 years ago

Hey great changes! I like the use of your comments as well as seperating the styling in the menu component. One thing is, the commit you made for the changes didn't link the issue correctly. The number needs to be connected to the # (#143), you added a space (# 143). This wont link the issue. If you can just change that and add somewhere in the name that this was a PR fix, Ill accept it