Alessandro100 / concordia-campus-guide

React project that allows navigation of concordia campuses
GNU General Public License v3.0
1 stars 0 forks source link

base color blind mode off staging #171

Closed Kresten24 closed 4 years ago

Kresten24 commented 4 years ago

Another thing is, wouldn't it be more efficient to change the colors in Colors.tsx instead of passing the settings to all components?

The main issue with this approach is backwards compatibility. Everyone is using default exports "Colors" as a constant. Changing that would require changing all other code that deal with Colors. I preferred passing the option and making the feature optional for now rather than clashing with existing code. Once things are more stable, it can be changed.
I updated the branch the bug should be resolved now