Feature/#145 google calendar integration

Alessandro100 / concordia-campus-guide

React project that allows navigation of concordia campuses

GNU General Public License v3.0

1 stars 0 forks source link

Feature/#145 google calendar integration #175

Closed wltrf closed 4 years ago

wltrf commented 4 years ago

The purpose of this pull request is to ask for feedback. Do not merge before my confirmation as there are still some tests that need to be written. Known issues:

Sometimes need to click "sync calendar" and login twice. This wasn't a problem outside of the menu, but inside the menu there seems to be a re-rendering happening, which leads to next issue.
When a re-render happens (e.g. close and open back menu), need to click "sync calendar" and login again.

wltrf commented 4 years ago

linking of commits to JIRA bug reports/features: not done!

I had done that when creating the PR, seems like it didn't save or I did something wrong. Added it back.

We don't save the user token in memory

I was thinking of using global, but the asyncstorage option you propose seems better.

Will push new changes soon.

wltrf commented 4 years ago

@Alessandro100 ready to merge.