search

AlessandroAU / Chorus32-ESP32LapTimer

This is an ESP32 port of the popular Chorus RF Laptimer
GNU General Public License v3.0
85 stars 33 forks source link

Set the license to GPLv3 #114

Closed Smeat closed 4 years ago

Smeat commented 4 years ago

Since only @swampmonster and me had a preference I decided to open a PR with the GPL ;P Still open for arguments though.

Apart from personal preferences this would give us the most freedom in using code from other projects. There is no problem using MIT/X11 code and we can use GPL licensed code (like from Betaflight or pidflight-lap (another racetimer))

Closes #108 and solves the licencing issues with the original project.

swampmonster commented 4 years ago

I’m good with GPLv3 so 👍 from me. We do need to spend some time figuring out what code might have come from elsewhere though so we give proper attribution.

Smeat commented 4 years ago

The only other external components I can think of would be the css, filter and crc. css is CC-BY and properly attributed. Not sure how generated code like the filter is handled, but it is attributed and will be replaced soon (once I find the time to test on proper hardware T_T) The creator of the crc generator explicitly says "the author of pycrc will not claim any copyright on the generated code"

Other than that everything else should be created by one of the contributors

swampmonster commented 4 years ago

The only other external components I can think of would be the css, filter and crc. css is CC-BY and properly attributed. Not sure how generated code like the filter is handled, but it is attributed and will be replaced soon (once I find the time to test on proper hardware T_T) The creator of the crc generator explicitly says "the author of pycrc will not claim any copyright on the generated code"

Other than that everything else should be created by one of the contributors

Sounds like we’re all set then!