AlessandroYorba / Alduin

A Vim Colorscheme
447 stars 26 forks source link

SpellBad is hard on the eyes in terminal #14

Closed gpakosz closed 7 years ago

gpakosz commented 8 years ago

Is there something broken on my side or is the SpellBad highlight group hard on the eyes?

image

image

AlessandroYorba commented 8 years ago

You're absolutely right. It makes my eyes sweat! Truth be told, I wasn't sure what values to use for any of the Spelling HL groups. What you're seeing is a clash of my theme color Windhelm and Vim referencing the terminal theme colors.

Are there any other vim color schemes that you'd like me to look at that got SpellBad right? Or do you have any suggestions on how it should look? Thanks for the feedback.

gpakosz commented 8 years ago

I don't know really :) Maybe make it close to the GUI look? That is red underline (even though in GUI it's a curvy underline)

image

AlessandroYorba commented 8 years ago

@gpakosz try the latest commit. I added 4 new colors for the Spelling HL groups. I tried my best to add colors that are visible and that stand out from the other theme colors. Give it a shot and let me know if they help you out.

gpakosz commented 8 years ago

👍 looks good to me! Thanks

AlessandroYorba commented 8 years ago

Awesome! Thank you

gangelop commented 8 years ago

Awesome. Time for release 2.4.5 maybe? spell

AlessandroYorba commented 8 years ago

@lathan good call. Working on that today.

AlessandroYorba commented 8 years ago

@lathan version 3 is tagged

gangelop commented 8 years ago

ty @AlessandroYorba !