search

AlessandroYorba / Alduin

A Vim Colorscheme
447 stars 26 forks source link

LineNr highlight group #6

Closed AlessandroYorba closed 7 years ago

AlessandroYorba commented 8 years ago

iTerm 2 Screenshot: Default LineNr ctermfg=237 ctermbg=233 guifg=#3a3a3a guibg=#121212 linenr_default

AlessandroYorba commented 8 years ago

iTerm 2 Screenshot: Ethereal Mode LineNr ctermfg=236 ctermbg=16 guifg=#303030 guibg=#000000 linenr_ethereal

The foreground color for the LineNr when in Ethereal mode is in fact darker the LineNr for Alduin default. To me the default setting is legible but the Ethereal Mode is too dark

ghost commented 8 years ago

How about LineNr ctermfg=243 ctermbg=235 guifg=#767676 guibg=#262626 and for "81" in this screenshot, the same colour as the comment on the same line (I'm not sure how to set that):

screenshot_2016-02-17_22-23-09

AlessandroYorba commented 8 years ago

Let me plug in your values to see how they look on my end.

AlessandroYorba commented 8 years ago

Here's the values you provided so I can compare your screenshot with mine: Ethereal Mode: LineNr ctermfg=243 ctermbg=235 guifg=#303030 guibg=#000000 linenroption

AlessandroYorba commented 8 years ago

While I spend some time considering your request, here's a small snippet you can add to the very bottom of your alduin.vim. It should display the lineNr and CursorLineNr that you want in both the default alduin and Ethereal mode: 

"Lighter Line Number Settings
hi LineNr ctermfg=243 ctermbg=235

"Winterhold CursorLine Number Color
hi CursorLineNR ctermfg=101

Please note that if you update alduin to any new commits, you have to add the snippet back in. Also, are you using Terminator?

ghost commented 8 years ago

Here's what works for me.

Terminator: screenshot_2016-02-18_09-46-02

GUI: screenshot_2016-02-18_09-46-53

As you can see, I had some difficulty trying to get the GUI's background colour the same as the cterm's. I actually prefer the GUI's. This is with g:alduin_Shout_Become_Ethereal set.

I have some other alterations that I'd like to suggest. Shall I make separate issues for them?

AlessandroYorba commented 8 years ago

I apologize. I gave you just the terminals values earlier. If you are interested, here's the matching GUI values for the LineNr and CursorLineNR based on the xterm color chart; However, It sounds like you're pleased with the GUI values that you added:

"Lighter Line Number Settings
hi LineNr ctermfg=243 ctermbg=235 guifg=#767676 guibg=#262626

"Winterhold CursorLine Number Color
hi CursorLineNR ctermfg=101 guifg=#87875f

nightvigilgui

nightvigilgui_ethereal

In regards to other suggestions, yes please open another issue ticket. Let's leave this one open in case others have any input on the subject.

Thank you btw!

ghost commented 8 years ago

Yes! What you pasted in that last comment is perfect for the numbers :-) (IMHO!)