Closed tertium closed 7 years ago
Good point! I will be introducing a new mode that will remove UI colors in despacio only leaving the text. Something similar to "hi Normal ctermbg=NONE".
Also, I will take a new look at the statusline colors. I do see your point about the colors in the statusline. The desktop monitor I'm using was calibrated and I can see the color separation clearly but when I use MacbookPro it is very hard to tell the difference. I'll keep you posted. Here's a screen of Midnight Mode right now: Midnight
For the sake of experience, please try Midnight or Pitch with a horizontal split between two windows with some highlighting in them (say, two source code files). I definitely have a hard time seeing where ends one window and starts another one :)
Agreed! The StatusLine and StatusLineNc needs to be either a lighter grey background or a stronger color. I'll send some screenshots over later today
@tertium is the StatusLine and StatusLineNC noticeable in Sunset and Twilight Mode? Is sounds to me like the 2 mode to really focus on is Midnight and Pitch
Finally settled on ctermbg=180 for StatusLine and StatusLineNC
Current StatusLine is Cream color cterm:180 hex:#dfaf87 source:http://www.colorhexa.com/dfaf87
I'm considering changing to Oak color cterm:137 hex:#af875f http://www.colorhexa.com/af875f
I spent some time pondering this, and I must admit that I do prefer your initial approach of using the same gray background for StatusLine, StatusLineNC, the window/tab delimiters, for Pmenu, etc. The current revision loses to that, in my opinion, in four regards:
It goes without saying that all of the above is subjective and nobody reads the passive status line anyway. Nevertheless, I would like to suggest an alternative solution: what if Despacio goes back to using a common gray background for all delimiters (including the status line), but for Midnight and Pitch (and maybe for Twighlight) this background is brighter than the normal text background — not by much, but enough to make the delimiters visible, which would address the initial issue I had with them.
Just for reference, I am currently using a ctermbg=0 for Normal (pitchier than Pitch), ctermbg=235 for all delimiters including the status line (as in the Day mode before 53c361e1c41effb1dcc1f2fabe368ec06a1a5dc8), and ctermfg=244 for the text in delimiters and also for the comments (slightly brighter than in Day without blending with the normal foreground). Couldn't be happier :)
@tertium good feedback for sure!!! Thank you. I'll post example code and screenshots for us to debate.
BTW, I did have a very similar issue with regards to the Pmenu in Sierra. I originally had a Pmenu that worked like version 1 of Despacio. It was one tick darker than the background for each mode set. For example, a Day( 236 ) background for Normal had a Sunset( 235 ) background for the Pmenu. Stepping down the color worked but as soon as I started using Midnight or Pitch it became increasingly harder to distinguish the Pmenu background. So I very much like your idea of changing it to something brighter than the normal background of the mode set. This was exactly how I addressed the issue with Sierra. I used Stone ( 245 ) for the background on Pmenu for all modes and then used the mode color for the foreground.
hi Pmenu ctermbg=245 ctermfg=233
BTW for all your custom settings are you also setting the CursorLine ctermbg=NONE? Or do you use a cursorline? If so, what color do you use?
I do not use CursorLine, so I didn't touch it. I tried to experiment with it now, and I agree with setting it one point brighter than the normal background color — at least for Midnight and Pitch. For Day, Sunset, and Twilight, it might be interesting to set it one point darker than the normal bg [*]. Also, I believe, CursorColumn must have the same setting as CursorLine. And ColorColumn must be something else, as it is used for different purposes.
[*] And before you reply "But one point darker would be the background of delimiters!" — I experimented with that, too, and it seems to me that I enjoy it most when for Day/Sunset/Twilight the delimiter bg is 3 points darker than the normal bg (233 for Day, 232 for Sunset, 16 for Twilight), and for Midnight/Pitch/Black it is 3 points brighter (236 for Midnight, 235 for Pitch, and 234 for Black). As for the delimiter fg and comments, 244 seems to be working okay with everything, except maybe Day (comments should be brighter) and Midnight (delimiter fg should be brighter).
I sent you a PR that implements these modifications (together with some tidying/factorisation that you might find useful in any case). Feel free to take whatever you feel like.
In both Twilight and Midnight, the status line is nigh indiscernible from the normal background, which is stressful when working with several windows at once, especially with horizontal splits. I understand that Despacio generally aims for low contrast, but I'd argue that it is rather important to have visible separation between the text areas and service areas (status, splits, tabs, line numbers, etc.).
While waiting for the Pitch mode, I find it most comfortable to use Day combined with "hi Normal ctermbg=NONE" (and my terminal background is simply black).