search

AlessandroYorba / Sierra

A Vim Colorscheme
297 stars 22 forks source link

Colorscheme not getting propagated to :term #9

Open kishikaisei opened 4 years ago

kishikaisei commented 4 years ago

So I am running nvim 0.5.0 on win 10 and when I open lazygit, it has some ugly colours that has nothing to do with the colorscheme, alternatively, gruvbox (and most fonts), colourises lazygit. It will make more sense in the screenshots below:

  1. This is running lazygit with sierra theme, the colours are not from sierra it seems: image
  2. And here gruvbox' example, where lazygit gets nice colours, in harmony with the theme: image Can this be fixed?
AlessandroYorba commented 4 years ago

@kishikaisei Yep good find. I'll add term support shortly! Thank you

kishikaisei commented 4 years ago

Well thank you, love your work (bought keyboard keycaps that kind of resembles the colourscheme XD still didn't arrive though).

AlessandroYorba commented 4 years ago

@kishikaisei I've been playing around with Sierra. Check out this branch: https://github.com/AlessandroYorba/Sierra/tree/nightly

I've added terminal colors but I'm not entirely sure if they are correct. Your input is welcome

kishikaisei commented 4 years ago

Downloaded the nightly version, but it doesn't seem to work, I tried it with lazygit and lf file manager. What I did is to run nvim in a gui app, I tried neovide, gonvim, and nvim-qt, neither showed the sexy colours.

AlessandroYorba commented 4 years ago

@kishikaisei Looking into it. I followed the vim help on terminal window color groups and I've tested it using MacVim and terminal vim. Looks okay on my end. I'm exploring the idea that NVIM uses unique variable names.

kishikaisei commented 4 years ago

Strange, tried it again, still the same, tried it on WSL2 (linux on windows) and nothing either. I was checking colorschemes, and ayu gets to terminal and the code seems clean? maybe that will help? Ayu.vim