search

AlessioDP / libby

A runtime dependency management library for plugins running in Java-based Minecraft server platforms.
MIT License
81 stars 20 forks source link

Does not find dependencies in repository in version folder if subversions are present #15

Closed Skjolberg closed 1 year ago

Skjolberg commented 1 year ago

i explain, when in the versions folder in the repository there are more folders containing subversions... libby is not able to use it.

example: https://s01.oss.sonatype.org/content/repositories/snapshots/net/kyori/examination-api/1.3.1-SNAPSHOT/

as seen in the following repo, there are subversions inside the version "1.3.1-SNAPSHOT", the same would happen in case there are folders indicating the subversions, see the example here: https://repo.spongepowered.org/#browse/browse:maven-snapshots:org%2Fspongepowered%2Fconfigurate-core%2F4.2.0-SNAPSHOT

frengor commented 1 year ago

The problem is that Libby doesn't currently treat SNAPSHOT dependencies specially to get the latest published artifact. It should ideally fetch the maven-metadata.xml file before downloading the dependency, in order to know which one to download.