AlessioMorale / ld06_lidar

ROS1 package for LDRobotic LD06 Lidar
37 stars 25 forks source link

fix lidar mirror issue, taken from linorobot/ldlidar, commit named 'i… #11

Open PaddyCube opened 2 years ago

PaddyCube commented 2 years ago

Related to this issue https://github.com/AlessioMorale/ld06_lidar/issues/10 I was able to fix this. The fiy was taken from linorobot/ldlidar repo, which is mostly the same but for ROS2. They also discovered a mirrored laser scan

AlessioMorale commented 2 years ago

Thanks for spotting the issue! just a note: I think it is better to keep the binary files ( docs/1628055158875552.rar, docs/lidar_uniform_64bit.zip, docs/sdk_ld06_ros.rar) out of the GIT repository. The application is not really useful in most of the situations (and forces to donwload almost 100MB of stuffs every time you clone this repo). The initial version of the sdk is available in the GIT history for this repo (here)

PaddyCube commented 2 years ago

Thanks for spotting the issue! just a note: I think it is better to keep the binary files ( docs/1628055158875552.rar, docs/lidar_uniform_64bit.zip, docs/sdk_ld06_ros.rar) out of the GIT repository. The application is not really useful in most of the situations (and forces to donwload almost 100MB of stuffs every time you clone this repo). The initial version of the sdk is available in the GIT history for this repo (here)

Hello, thanks for this info. I took them into my repo as only rare information can be found about this lidar. I've seen docs and examples deleted in past for others, rarely used chinese sensors. But I agree with you that it doesn't make sense to download all of them again and again.