search

Alex-At-Home / cbb-on-off-analyzer

A not-so-simple-any-more! SPA for rendering college basketball on/off analysis
https://cbb-on-off-analyzer.now.sh
Apache License 2.0
0 stars 2 forks source link

Roster view in team stats doesn't show the ORtgs (other fields?) correctly #220

Closed Alex-At-Home closed 1 year ago

Alex-At-Home commented 1 year ago

Eg http://localhost:3000/OnOffAnalyzer?autoOffQuery=true&baseQuery=&gender=Men&maxRank=400&minRank=0&offQuery=NOT%20%28Emilien%20%29&onQuery=Emilien%20&showRoster=true&team=Maryland&year=2022%2F23&

Check out Emilien, Reese on/off etc

Alex-At-Home commented 1 year ago

OK it's a bit tricky ... I think the issue is teamStats.baseline which should be the on/off number instead

            const playerInfo = LineupTableUtils.buildBaselinePlayerInfo(
              playerStatsBy0AB, globalRosterStatsByCode, teamStats.baseline, avgEfficiency, adjustForLuck, 
              luckConfig.base, manualOverridesAsMap || {}
            );
Alex-At-Home commented 1 year ago

Fixed by 6674bc3aedf3ae37df447f5611b4b16f32b6c7b7