Alex-At-Home / cbb-on-off-analyzer

A not-so-simple-any-more! SPA for rendering college basketball on/off analysis
https://cbb-on-off-analyzer.now.sh
Apache License 2.0
0 stars 2 forks source link

Use date as a sort of game id #223

Open Alex-At-Home opened 1 year ago

Alex-At-Home commented 1 year ago

It turns out I just take the date part of the "Game date:" in the incoming data (apparently the time part is optional, or at least was in 2018!) and then append 17:00 to it

Each lineup date is then box_lineup + start_time (which is stupid, why not just keep it all fixed!)

Anyway what this means is that it actually should be totally safe to just use the day portion of the lineup dates as a game id (in conjunction with opponent)

(safe in the sense that if this would fail, eg because 2 different games against the same opponent on the same day would fail in the same way as all my grovelling with hours)

Definitely re-check against the 20/21 season where there are some good examples of teams playing back-to-back (which is what I thought had empirically prompted all the grovelling ... but turns out I was just "pre-grovelling" I think?!)