search

Alex-D / Cookies-EU-banner

1kb vanilla JS script which manages cookies consent banner display like asked by GDPR
http://alex-d.github.io/Cookies-EU-banner/
MIT License
441 stars 57 forks source link

Safari Version 8.0.6 (10600.6.3) showBanner is not executed #11

Closed merqurio closed 9 years ago

merqurio commented 9 years ago

Hi !

I have a problem on Safari Version 8.0.6 (10600.6.3), where the showBanner function is not executed.

I think the problem is that init() is not run and therefor showBanner neither. My guess is that the problem is in line 32 when checkijng if it's a bot or not :

> var a = new CookiesEuBanner(function(){console.log("Hello world")});
< undefined
> a.init()
< false

I wish this helps :grinning:

Alex-D commented 9 years ago

Hi!

In fact, there is a bug here. I've test and it's from: https://github.com/Alex-D/Cookies-EU-banner/blob/master/src/cookies-eu-banner.js#L107

It's works if I replace !== by just !=

I apply this patch ASAP.

merqurio commented 9 years ago

Wow , that was a fast answer, Thank you very much ! If there's something else I can help with, please let me know.

Alex-D commented 9 years ago

Fix'd in 1.2.7 by this commit: https://github.com/Alex-D/Cookies-EU-banner/commit/19c8b88e98351bf177c2c3736589fb5480406d77