search

Alex-D / Cookies-EU-banner

1kb vanilla JS script which manages cookies consent banner display like asked by GDPR
http://alex-d.github.io/Cookies-EU-banner/
MIT License
439 stars 57 forks source link

Latest release references dist/cookies-eu-banner.js which doesn't exist. #34

Closed SiAshbery closed 6 years ago

SiAshbery commented 6 years ago

The main parameter in package.json refers to dist/cookies-eu-banner.js, which isn't included in the release itself, and as such hasn't been working properly for us unless we manually run npm run build in the downloaded node module.

Release 1.2.10 Included the dist/ folder and works fine as a result. Was there a specific reason it was removed and included in .gitignore?

Would it be easier to point main to src/cookies-eu-banner.js instead?

Alex-D commented 6 years ago

You right, I've just released the 1.2.14 which should fix that :)

rubycon commented 5 years ago

@Alex-D same issue with the latest release 1.2.15.

Alex-D commented 5 years ago

Should be fixed in 1.2.16.

Sorry again ^^'

rubycon commented 5 years ago

It works great now! Thanks.

DRicciardi commented 5 years ago

Same issue now. The demo is also referencing dist/cookies-eu-banner.min.js so it doesn't work when you download the release.

Alex-D commented 5 years ago

The file is here in the latest release: https://github.com/Alex-D/Cookies-EU-banner/blob/1.2.16/dist/cookies-eu-banner.min.js

I did not understand your point :/

Also, the download button is not up to date. Use this one: https://github.com/Alex-D/Cookies-EU-banner/archive/1.2.16.zip

DRicciardi commented 5 years ago

Oh, I just used the download link and I didn't see the dist folder in the master branch.

No biggie. Thanks for your work!