search

Alex-D / Cookies-EU-banner

1kb vanilla JS script which manages cookies consent banner display like asked by GDPR
http://alex-d.github.io/Cookies-EU-banner/
MIT License
439 stars 57 forks source link

Replace inline style by hidden attribute... #66

Open robsonsobral opened 2 years ago

robsonsobral commented 2 years ago

...in a retro compatible way

closes #48

robsonsobral commented 2 years ago

Rethinking... My code is retro-compatible only in case the style is set inline. I guess I should change it.

robsonsobral commented 2 years ago

FIXED.

robsonsobral commented 2 years ago

I think I can drop IE8 support now and use classList

Are you sure? Move to v3 just because of that? No adding tests? I guess we could, at least, add code linting. Of course, keeping the simplicity and the small size.

dataset is also IE10+

Alex-D commented 2 years ago

I will take some time to clean that with my eslint ruleset

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

robsonsobral commented 2 years ago

I will take some time to clean that with my eslint ruleset

Let's use Airbnb! It's a standard.

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

Changes of support are MAJOR, but as that's already done on v2, I guess we can just update the README.

I wouldn't reduce support for things so simple to resolve, but you're the boss!

robsonsobral commented 2 years ago

We could move to ESBuild as well.

robsonsobral commented 2 years ago

The constant of the world is to change, @Alex-D .

https://github.com/WICG/display-locking/blob/main/explainers/hidden-content-explainer.md