search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
4k stars 613 forks source link

Remove background colour removes all styles #1179

Open moseleyi opened 3 years ago

moseleyi commented 3 years ago

Description

When using color plugin, the option Remove background color removes not only the background color but all styles, even if there is no background color applied

How to reproduce?

  1. Write text
  2. Select text and change color and maybe a custom font and size
  3. Click Remove background color

Expected result: nothing happens Actual result: all styles are removed (whole attribute style is removed)

Alex-D commented 3 years ago

Ah nice catch!

Due to this removeFormat call:

https://github.com/Alex-D/Trumbowyg/blob/1a3c888d240d84854774f31aa6dedf57ecf4dbff/plugins/colors/trumbowyg.colors.js#L209