search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
3.99k stars 612 forks source link

Update emoji codepoints to JoyPixels v6.6.0 #1257

Closed zanechua closed 2 years ago

zanechua commented 2 years ago

Would be savvy if we could get this labeled as hacktoberfest-accepted

zanechua commented 2 years ago

@Grafikart

Are you maintaining this repo instead of Alex now?

Details here: https://github.com/Alex-D/Trumbowyg/pull/827

Basically this updates the codepoints for emoji's so we'll get access to newer emojis in the emoji plugin.

No one else seems to be maintaining the codepoints and since I was the one who made the initial change, it's kinda my baby at this point.

Alex-D commented 2 years ago

Thank you :)

As a side note: everyone is free to review the code, so if @Grafikart wanted to review it, he can :) And I understand that a PR without any message can be hard to review.

Also, I've read the hacktoberfest things, it seems that merging works the same as the label. I do not want to create labels dedicated to hacktoberfest since it makes no sens other months ^^

zanechua commented 2 years ago

Oh that's neat. :)

Sure, no qualms about that. Thanks @Alex-D and @Grafikart