search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
4.02k stars 614 forks source link

CSS renovation #1269

Closed timint closed 1 year ago

timint commented 2 years ago

A bunch of fixes, adjustments, and improvements to CSS. See list of commits

Alex-D commented 2 years ago

I see a lot of changes here in the final style, and it is not just a refactor, so I need to test that deeper.

timint commented 2 years ago

Sure, branch it, test it. See how you like it. 👍 I am better at CSS than i am at gulp. So I'm sure you will find some nice upgrades. 🙂

There is also a possibility to use CSS variables today var(--trumbowyg-this-that) if you would like them defined on the client side. https://caniuse.com/?search=css%20variables

Alex-D commented 1 year ago

Partially merged, thank you :)

I do not want to use CSS custom properties in version 2 since it can be a big breaking change for compatibility.

timint commented 1 year ago

Here is an implementation of CSS variables that might inspire you: https://github.com/litecart/litecart/blob/dev/public_html/ext/trumbowyg/ui/trumbowyg.scss