search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
3.99k stars 612 forks source link

* Fix duplicate banner comments in minified files #1270

Closed timint closed 2 years ago

timint commented 2 years ago

(cherry picked from commit 508ec4493df3dd2ba630b2b2c39da45b4a0aec1a)

Alex-D commented 2 years ago

What's the issue fixed? I did not get why this is the good way to fix it, instead of removing comments from source files

timint commented 2 years ago

If I remember right from back in august the minified files had duplicate txt banners. I can't confirm that the release is that way today. But I had those when running npm run build. I think the problem was that you applied the banner for the distributed versions. Then used the distributed versions to build minified versions where the banner was applied again.

/** Trumbowyg v2.25.1 - A lightweight WYSIWYG editor - alex-d.github.io/Trumbowyg - License MIT - Author : Alexandre Demode (Alex-D) / alex-d.fr */
/** Trumbowyg v2.25.1 - A lightweight WYSIWYG editor - alex-d.github.io/Trumbowyg - License MIT - Author : Alexandre Demode (Alex-D) / alex-d.fr */
...
Alex-D commented 2 years ago

I've done that instead: https://github.com/Alex-D/Trumbowyg/commit/055a4171e17ca6b6d60751d4558fd5ebd8ccd270

Seems more clean to me :)