Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
3.98k stars 609 forks source link

Where to get additional icons? #1320

Closed urosg80 closed 1 year ago

urosg80 commented 2 years ago

I am working on some additional functionality (column resizing, table borders, CSS class styling per cell, row, column, table) for Table plugin but would need some more icons for the toolbar.

Are the default icons from some icon pack or are all your artwork @Alex-D?

Alex-D commented 2 years ago

Amost all Icons were made by @adriengervaix for Trumbowyg. So there is no other icons available. What is the need?

urosg80 commented 2 years ago

At this moment I would like to include icons for setting table borders.

For now I have implemented functionality for these types - excerpt from MS Word: borders

For CSS class styling I modified the icons that come with Trumbowyg like this: css

Small demo of my changes so far:

https://user-images.githubusercontent.com/11760571/185419498-1844fb0f-3b91-4907-8afb-dbae47896ccf.mp4

Alex-D commented 2 years ago

Oh, nice! :) If you can list all needed icons, I can check if I can create them or ask the original designer

urosg80 commented 2 years ago

If the icons I made for CSS class settings (the yellow fill) are OK then these I can leave; but the icons I would like to use are the ones marked in the excerpt from MS Word - for:

Then I think it would be nice to give the user the option to select border type - so extra icons are needed:

And with that also the border width - this would be a "spin edit".

Alex-D commented 1 year ago

Please submit a PR, this will be more simpler for me to follow :)

urosg80 commented 1 year ago

Will do as soon as possible, unfortunately I am currently busy with other projects.

Alex-D commented 1 year ago

I made the last table icons, so I could create more.

Note that since then, the Table plugin has been completely rewritten.

I close this, feel free to post here or reopen if needed :)