Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
3.98k stars 609 forks source link

Update trumbowyg.js - add predefined targets for anchor elements #1326

Closed coelhudo closed 1 year ago

coelhudo commented 1 year ago

In the current version, when a link is inserted, that's the modal dialog that shows up:

image

The target is a text field. However, the target attribute only accepts four keywords: _self, _blank, _parent, and _top.

I changed the code to use a drop-down menu instead of a text field, so the users don't need to type the value.

image

image

Alex-D commented 1 year ago

Thank you! :) I will review that soon, seems good, but I need to try it for real, and maybe make option labels translated

Alex-D commented 1 year ago

Merged:

Thank you :)