Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
4k stars 614 forks source link

Giphy plugin causes slow image loading due to not using limit query parameter #1436

Open synth opened 9 months ago

synth commented 9 months ago

Currently, the Giphy plugin does not include limit query parameter and can result in a really slow response from Giphy. I have seen this be upwards of 20s response time before images will load.

In my testing, simply adding a limit parameter to something like 50 will result in sub 1s response times.

This can be worked around by adding limit to the "rating" plugin option, but this is hacky. This plugin should support all the options that Giphy has to be future proof:

image

UPDATE: I originally thought just limit was the issue. In actuality it was more about the "renditions" used when the picker loads lots of gifs at once.