search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
3.96k stars 606 forks source link

Support for jQuery 4 #1442

Closed marcellov7 closed 4 months ago

marcellov7 commented 4 months ago

Hi,

I'm an enthusiastic user of Trumbowyg and greatly appreciate its features and effectiveness. However, with the recent announcement of the release of jQuery 4 and its promises to significantly improve library performance, I was wondering if there are plans to ensure Trumbowyg compatibility with this new version of jQuery. https://blog.jquery.com/2024/02/06/jquery-4-0-0-beta/

I understand that Trumbowyg relies on jQuery and that the upgrade may take time and effort, but considering the potential benefits in terms of performance and future compatibility, it would be extremely helpful for the community to know if there is a commitment to making Trumbowyg compatible with jQuery 4.

Is there a roadmap or defined plan for this? Additionally, if there are opportunities to contribute or support this effort, I would be happy to provide my assistance.

In general it seems to me to be running, but from what I can see $.isArray has been deprecated and is present in a few places, but it seems easy to change.

Thank you

Alex-D commented 4 months ago

Hey!

It seems legit to want Trumbowyg working with jQuery 4. I will check that when I have time to work on it.

I appreciate your interest in this project :)

Alex-D commented 4 months ago

I've worked on that today. It was easy to make it work with jQuery since the code did not use deprecated APIs so much.

I'm trying to make Trumbowyg compatible with the slim version by removing $.ajax for fetch.

You can see that on the develop branch right now :)

Alex-D commented 4 months ago

I've just published a new release of Trumbowyg, making the lib ready for jQuery 4.

I've also worked on removing the need for $.ajax, which should make it compatible with jQuery 4 Slim.

See the Release: https://github.com/Alex-D/Trumbowyg/releases/tag/v2.28.0