search

Alex-D / Trumbowyg

A lightweight and amazing WYSIWYG JavaScript editor under 10kB
https://alex-d.github.io/Trumbowyg
MIT License
4.02k stars 614 forks source link

Esc-key doesn't work in document after initialization #360

Closed Duncank closed 8 years ago

Duncank commented 8 years ago

After including Trumbowyg in our dashboard, all window.onkeydown actions that use the escape key (27) won't work.

I'm not sure what the best way to fix this is, but for now I've deleted the return false that follows t.closeModal() on line 629. Maybe it should check if a modal is open and return true if it is not.

Browser: Chrome 54 OS; Windows 10 Resolution: 1920x1080

Alex-D commented 8 years ago

Maybe it should check if a modal is open and return true if it is not.

I think yes. Sorry for this mistake. I will check that asap.