Alex-Werner / dash-price

Dash Chrome Extension for monitoring
4 stars 8 forks source link

Re-center the notification range when an alert is issued. #2

Open kpereira opened 7 years ago

kpereira commented 7 years ago

Hi, great extension. I am finding it useful.

I am wondering if you are able to add the option to re-center the price notification range when an alert is issued.

For example:

Alert is set for when the price is below 100, or above 150. When the price goes to 155, the alerts are changed to when the price is below 130 and above 180. New alerts are offset -25 and +25 respectively of the current new price, so alerts are now re-centered. It can also work for different - and + offset (-10 but +30).

Otherwise I find myself re-setting it my self. It seems to set itself to 0 when a price alert is reached.

Thank you.

kpereira commented 7 years ago

Nevermind. I see that the version I am using is simply forked from this github repo. I think :S

Alex-Werner commented 7 years ago

Hi @kpereira !

Thank you for having open an issue.

I feel it somewhat annoying to work with settings as of today. So I need to do things about it!

But I must admit that I might have some trouble to understand what is the issue on price notification.

What you would like is that instead having notification telling you about new all time high and low, you want it to warn everytime you goes above/under your offset. And when it's done, you want it to be recentered keeping the same offset ?

It might be totally doable to do so. May be we could add percentage of it ?

Don't hesitate to tell me more about what you want and I will be bringing it (disabled by default).

Here is the repository for the Dash price extension. I did one (verrrry quickly) for Bitcoin (but I won't suggest you to use it ^^').

If you are using Dash Price Extension I might be able to help you on that.

Non related : Are you interested with having the ability to setup other coin and thus having background and template changing ?

kpereira commented 7 years ago

I am currently using a fork of this repo by another person so it may work a bit differently. The one I use is for XVG (Verge coin). So to answer your final question, I would be interested in it being able to monitor other coins (even better, more than one at the same time). I have not had a look at what this particular extension is capable of.

QUOTE "What you would like is that instead having notification telling you about new all time high and low, you want it to warn everytime you goes above/under your offset. And when it's done, you want it to be recentered keeping the same offset ?"

Yes that's exactly it. The fork I am using has implemented this feature, except without the automatic re-centering.

Alex-Werner commented 7 years ago

Trying to see more in details, I've downloaded the extension, lookup on the code, and made a P.R in microtaha code :

https://github.com/microtaha/dash-price/pull/2 https://github.com/microtaha/dash-price/pull/1

Unfortunately, I can't see big code modification, there for I cannot help you with that. I will need more information about the exact extension as I assumed it was this one :

https://chrome.google.com/webstore/detail/verge-xvg-price-ticker/mpkabbjfoeaojminpoflladbkhinbmbb?utm_source=chrome-app-launcher-info-dialog

Which means that there is low to none modification (only change in Dash => Verge) in the code Do you have the direct link may be?

kpereira commented 7 years ago

That's the exact one, although I will be discontinuing use of any extensions going forward. Thank you for your time.

On Wed, Jul 5, 2017 at 10:23 AM, Alex Werner notifications@github.com wrote:

Trying to see more in details, I've downloaded the extension, lookup on the code, and made a P.R in microtaha code :

microtaha#2 https://github.com/microtaha/dash-price/pull/2 microtaha#1 https://github.com/microtaha/dash-price/pull/1

Unfortunately, I can't see big code modification, there for I cannot help you with that. I will need more information about the exact extension as I assumed it was this one :

https://chrome.google.com/webstore/detail/verge-xvg-price-ticker/ mpkabbjfoeaojminpoflladbkhinbmbb?utm_source=chrome-app- launcher-info-dialog

Which means that there is low to none modification (only change in Dash => Verge) in the code Do you have the direct link may be?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Alex-Werner/dash-price/issues/2#issuecomment-312969984, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQgwuVEFWOarrrW2ldgECVoj-crYDMbks5sKtedgaJpZM4OMWOZ .

Alex-Werner commented 7 years ago

Sorry I cannot help you more =/ I might implement that idea in the Dash extension which will be for microtaha a way to get theses aswell in his repo (thus his extension).

(Do you have an issue with this extension that make you want to discontinuing them ?).

Have a nice day.

kpereira commented 7 years ago

No problem at all. I have decided extensions are a security risk until I can further investigate. Although, I may use this source code. On Wed, 5 Jul 2017 at 10:29 am Alex Werner notifications@github.com wrote:

Sorry I cannot help you more =/ I might implement that idea in the Dash extension which will be for microtaha a way to get theses aswell in his repo (thus his extension).

(Do you have an issue with this extension that make you want to discontinuing them ?).

Have a nice day.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Alex-Werner/dash-price/issues/2#issuecomment-312970401, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQgwnhCPmVOgGK40xVY4dUfePwqj_5rks5sKtj1gaJpZM4OMWOZ .

Alex-Werner commented 7 years ago

If I can help on that : i've look on the one you use (XVG), it's exactly the same as here (as of actual last version published). On this, in term of security, I know that trust should not be taken into account (even if my work is audited by the Dash community and others trying to learn what we are building in secret), but therefore I will give you this link : https://developer.chrome.com/extensions/contentSecurityPolicy

Which one of the measure Google setup to ensure security. And this is why I need your acceptation to retrieve data from ECB and coinmarketcap (and display notifications).

Worth noticing that inside an extension, we are working in quite the same limited context as any other website, actually, there is no difference between an extension (might differ for applications) and a website that you visit (we cannot access your cookies from other website for instance).

Given the review of the verge extension that I did. He provide the same type and security.

Good luck in your crypto-journey :D

(We release the new roadmap, you might want to check it up ;) : https://github.com/dashpay/dash-roadmap)

P.S : One issue I can forsee : If one install ALL the extension made by microtaha (he did it for more than 10 coins), coinmarketcap might not agree to have that much request to his API. You might also have a little RAM usage. Can't see much more than this :)

kpereira commented 7 years ago

Thank you for the extensive and useful information. I will take it all in to consideration for when I do finally investigate this further.

Good luck to you too!