search

Alex141 / CalcBinding

Advanced WPF Binding which supports expressions in Path property and other features
Apache License 2.0
638 stars 79 forks source link

Fixes parenthesis [#33] #35

Open marknuzz opened 8 years ago

marknuzz commented 8 years ago

There is some refactoring in here as well, to encapsulate some of the complexity.

marknuzz commented 8 years ago

Just noticed issues with this, based on the unit testing. Will have a fix.

marknuzz commented 8 years ago

Looks like the quick and dirty parser is not able to handle both Math functions and attached properties, due to the parenthesis needing to be handled differently. Context-dependent parsing would need to be employed, which make it more difficult. Still going to work on it.

marknuzz commented 8 years ago

The tests now pass, and the parser is more sophisticated now. Should pave the way for more complex calculations if those features should be needed at a later time

marknuzz commented 8 years ago

Might need to be cleaned up a bit, I didn't have time to really polish it, but added comments where I could

Alex141 commented 8 years ago

Thanks, good job! I review this soon, sorry, haven't enough time now

marknuzz commented 8 years ago

Any news?