search

Alex313031 / Chromium-Vector-Icons

Chrome Extension which draws vector .icon files in the Chromium repository.
https://chrome.google.com/webstore/detail/chromium-vector-icon-pain/cnlndebkegcfnbiknohgneobakigplhf
Apache License 2.0
7 stars 2 forks source link

Breaks for some icons. #1

Open cohenerickson opened 2 years ago

cohenerickson commented 2 years ago

Some icons such as the ones below don't display correctly.

https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/account_circle.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/content_copy.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/history.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/settings.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/google_color.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/location_on.icon https://chromium.googlesource.com/chromium/src/+/main/components/vector_icons/passkey.icon

dragonloverlord commented 1 year ago

I managed to fix this and opened pull request #2 to get it integrated basically the methods QUADRATIC_TO, R_QUADRATIC_TO, QUADRATIC_TO_SHORTHAND were missing/unimplemented and it looks like most round icons were using these methods.

Alex313031 commented 1 year ago

@dragonloverlord Thanks! Merged the request.

@dragonloverlord @cohenerickson Curious, how did y'all find out about this extension, and what do you use it for. Are you Chromium devs?

dragonloverlord commented 1 year ago

Not a Chromium dev but I have help with Chrome OS patches a few years back in a unofficial context. I also make chrome extensions for private use on a case by case basis for individuals with specific usage needs so I have a good bit of familiarity with chrome extension and there inner workings. As for this extension I found it on the thorium wiki and thought it was a rather interesting way to render text based image formats via SVG conversion which I have played around with before when making various mods for games like Starbound, Stardew Valley, and Skyrim to list a few. Personally I was more curious about the underlying technology in use by the extension than the extension its self but in the process of tinkering with it I managed to fix the bug in question and figured the least I could do was share my discovery.

I was actually just checking for updates on thorium when I ran across the extension so kind of luck really. Also I got to say thorium AVX2 is really useful for power users like me who could have multiple tabs open all well running a resource intensive process such as a game in 4K on the side so keep up the good work and glad I could help even if it was just a simple fix I stumbled across in this extension.

cohenerickson commented 1 year ago

Kind of surprised you asked, I'm not a Chromium dev, just a teenager with a hobby for programming. I'm not sure how I initially found this extension but I was looking for some way to convert the icons to an SVG for one of my projects. I can't exactly remember what project it was for but it was either to make an operating system in the browser styled like Chrome OS or for a Chrome styled web proxy. Neither of those really went anywhere but I have since been working on a similar project meant to look like Firefox (cohenerickson/Velocity).