Specify Flags for `./mach` bootstrap in `trunk.sh`

Alex313031 / Mercury

Firefox fork with compiler optimizations and patches from Librewolf, Waterfox, and GNU IceCat.

https://thorium.rocks/mercury

Mozilla Public License 2.0

1.16k stars 25 forks source link

Specify Flags for `./mach` bootstrap in `trunk.sh` #129

Closed wagesj45 closed 7 months ago

wagesj45 commented 7 months ago

Since we're building without artifacts enabled, we can pass --application-choice "Firefox for Desktop" into ./mach bootstrap.

To support automation, we can pass --no-system-chances into ./mach bootstrap to avoid the mercurial setup wizard.

wagesj45 commented 7 months ago

I'm sorry I'm not sure I understand your meaning. Do you mean that trunk.sh should be modified to to accept these parameters and pass those into ./mach? I'm not sure how else to run the bootstrap command in ./mach without requiring interactivity.

Example ./trunk.sh --no-interaction ...

...
if [[ " $* " =~ " --no-interaction " ]]; then
    ./mach bootstrap --application-choice "Firefox for Desktop" --no-system-changes
else
    ./mach bootstrap
fi &&
...

gz83 commented 7 months ago

You have understood my previous comment, but please also test thoroughly before modifying this PR.

@wagesj45

wagesj45 commented 7 months ago

I have explained my changes here. I chose not to put them behind a passed parameter because the single --application-choice value is in line with the official documentation. This is just doing what the HG_SETUP.md documentation already mandates.