modified bootstrap.sh to make it more helpful

Alex313031 / Mercury

Firefox fork with compiler optimizations and patches from Librewolf, Waterfox, and GNU IceCat.

https://thorium.rocks/mercury

Mozilla Public License 2.0

1.03k stars 26 forks source link

modified bootstrap.sh to make it more helpful #71

Closed formula-spectre closed 5 months ago

formula-spectre commented 8 months ago

what I did is

removed the mkdir /c stuff, it's not needed
curl the bootstrap.py script only if it's not present
make it so that every argument that is passed to bootstrap.sh is passed to bootstrap.py (in my investigations I found out that bootstrap.py has some interesting flags)

formula-spectre commented 8 months ago

it will be stored directly in Mecury's repo; it could be added to .gitignore, but I think that's a minor. if you mean the other scripts, I did not test them, since I modified only the bootstrap.sh file. I tested the new bootstrap.sh file and it works fine the parameters that can be passed to bootstrap.sh can pre-set which type of build should be (mozilla firefox w/wo artifacts, etc..), and other than that it should not have that much impact, you decide to use git as vcs.. mea culpa, I did not test it.

gz83 commented 8 months ago

OK, thanks for your work, this PR is LGTM for me, but needs final review by Alex

@Alex313031

Alex313031 commented 6 months ago

@formula-spectre @gz83 The reason why it has /c/ is because this is not for use on linux. I use this in MozillaBuild's git bash on windows to clone the repo quickly. However, the other stuff looks good. If you can modify ur PR I'll accept it.