Alex313031 / Thorium-Android

Thorium builds for Android (arm64 and arm32).
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
550 stars 10 forks source link

Being able to install extensions #12

Open sitolam opened 1 year ago

sitolam commented 1 year ago

Is your feature request related to a problem? Please describe. I was trying to install extensions from the Chrome Web Store when I noticed that that isn't possible. 😥

Describe the solution you'd like, including relevant patches or source I would like to be able to install extensions like in Kiwi Browser. 😎

Additional Notes I like this project a lot. 🤪 Good work. 🫡

boyka commented 1 year ago

this project is indeed amazing, the browser is smooth and fast.. if extension support was added I'd ditch all other browsers all together.

kenfink commented 1 year ago

+1

gz83 commented 1 year ago

Thanks for the advice

Greatz08 commented 1 year ago

@Alex313031 you did awesome job with browsers buddy,if possible can you add support for extensions like kiwi browser did for android , kiwi browser for android is also open source project which you can refer to if you need some guidance or idea for implementations and make this the best performance based browser with extension support on android.kiwi does have some glitches and issue but still i am using it rn because of extensions support. hope you add support for extension soon :-)

GeorgelPreput commented 1 year ago

+1 for this idea. Been using Kiwi Browser for a while, would love to have the extension support in Thorium Android too https://github.com/kiwibrowser/src

y-ziane commented 1 year ago

+1

obito512 commented 1 year ago

+1

dhrubo66 commented 1 year ago

+1

Insidevk18 commented 1 year ago

+1

gz83 commented 1 year ago

There is no guarantee that this issue will be resolved quickly.

The existing patches on the Internet are relatively old and require a lot of refactoring work.

github59173 commented 1 year ago

+1 Would be a huge win if it was implemented. Being able to run full extensions like Ublock Origin would be very nice.

ghostranger047 commented 1 year ago

+1

Candlemass commented 1 year ago

I'm also looking for this. Unfortunately I can't switch browsers on android until extension support is implemented.

7medina commented 10 months ago

+1

dnchshrp commented 9 months ago

+1

MulverineX commented 9 months ago

Microsoft Edge for Android is adding support for extensions as of this year, you can already play around with it in Canary today. If these changes to the codebase are going to reach upstream, that would make it leagues easier for this project to implement.

TheElectrinix commented 8 months ago

+1

moinologics commented 7 months ago

+1

brian6932 commented 7 months ago

If you have nothing better to say than +1, or that you like the idea, maybe you shouldn't say anything at all, reactions exist for a reason. People sub to these threads for status updates and alike, this isn't Reddit or 4chan, each time you make useless bumps, you ping people for no reason 😕.

Candlemass commented 7 months ago

If you have nothing better to say than +1, or that you like the idea, maybe you shouldn't say anything at all, reactions exist for a reason. People sub to these threads for status updates and alike, this isn't Reddit or 4chan, each time you make useless bumps, you ping people for no reason 😕.

If a single notification every couple of weeks is such a huge deal to you then maybe you should unsubscribe from the thread. Unsubscribing exists for a reason. Personally this is the last problem and deal breaking issue which prevents me from using this on android and I find those expressing interest in the same feature important for gauging interest. Such comments also act as a reminder to the dev to get on it. Grab a tissue and settle down.

MulverineX commented 7 months ago

All of Alex's work on thorium projects is volunteer hours. Bump comments to remind him to "get on it" are no more than entitlement and spam. There's a reason Refined Github automatically hides "+1" comments and many repos have bots that automatically hide them.

Is it a bummer that Firefox is slow on android and the rest of the options kinda suck for one reason or another? Yeah. But until Alex is being given a significant financial incentive by this community we shouldn't expect anything. This repo in particular seems to be have been nothing more than a pet project for him, not something with lots of work and commitment behind it like the desktop browser.

Candlemass commented 7 months ago

So is whining about notifications for a thread you're subscribed to and your self-righteous virtue signalling that contributes equally as little. Honestly, speed isn't everything in a browser and I would give up half of it if it meant more time allocated towards extension support because the internet without adblock is an intolerable dumpster fire. I've personally done just that opting to instead use Iceraven on android.

Either way, until such time that you put your money where you mouth is, providing significant financial donations, you aren't in any position to be criticising others in the exact same boat that post comments that don't align with your opinion.

I see pet project coding as no different than any other hobby and like a lot of hobbyists, devs are free to quit at any time. Github is full of abandoned projects "for a reason". Keep that in mind.

brian6932 commented 7 months ago

whining about notifications for a thread you're subscribed to

I simply stated that this isn't what issue trackers are for, they're for getting updates on the issues.

That's a lot of incorrectly used buzzword adjectives.

self-righteous

There's 0 moral discussion here.

virtue signaling

How am I seeking any social points by saying, I don't want to be pinged for your pointless comments? This isn't what issue trackers are for. If you want this type of social media experience, go to 4chan, Reddit, or Discord, not here.

If you don't understand what this site's for, that's on you. Stop blaming others for your retarded behavior when called out on it, you sound like an absolute child whose only coping mechanism for facing their mistakes is throwing tantrums.

Either way, until such time that you put your money where you mouth is, providing significant financial donations, you aren't in any position to be criticizing others in the exact same boat that post comments that don't align with your opinion.

I didn't comment, I only spoke up because Alex isn't active, and hasn't cleaned this thread themselves yet. Alex isn't responsible to close this issue, they don't even get paid for that. Take a step back and realize that your whole comment comes from a feeling of entitlement. If you don't want to be a nuisance to the repo, open a PR and implement the functionality yourself instead of being a waste of oxygen.

I see pet project coding as no different than any other hobby and like a lot of hobbyists, devs are free to quit at any time. Github is full of abandoned projects "for a reason". Keep that in mind.

How about you stop being a waste of oxygen and keep the projects you care about alive, instead of complaining in a corner like some kind of regretful cuck.

gz83 commented 7 months ago

Sorry, Alex has been unable to handle anything related to the github repo due to some unexpected reasons recently.

We have always wanted to enable the Android version to support the installation and management of extensions, and we are currently still looking for solutions to install and manage extensions.

Candlemass commented 7 months ago

whining about notifications for a thread you're subscribed to

I simply stated that this isn't what issue trackers are for, they're for getting updates on the issues.

That's a lot of incorrectly used buzzword adjectives.

self-righteous

There's 0 moral discussion here.

virtue signaling

How am I seeking any social points by saying, I don't want to be pinged for your pointless comments? This isn't what issue trackers are for. If you want this type of social media experience, go to 4chan, Reddit, or Discord, not here.

If you don't understand what this site's for, that's on you. Stop blaming others for your retarded behavior when called out on it, you sound like an absolute child whose only coping mechanism for facing their mistakes is throwing tantrums.

Either way, until such time that you put your money where you mouth is, providing significant financial donations, you aren't in any position to be criticizing others in the exact same boat that post comments that don't align with your opinion.

I didn't comment, I only spoke up because Alex isn't active, and hasn't cleaned this thread themselves yet. Alex isn't responsible to close this issue, they don't even get paid for that. Take a step back and realize that your whole comment comes from a feeling of entitlement. If you don't want to be a nuisance to the repo, open a PR and implement the functionality yourself instead of being a waste of oxygen.

I see pet project coding as no different than any other hobby and like a lot of hobbyists, devs are free to quit at any time. Github is full of abandoned projects "for a reason". Keep that in mind.

How about you stop being a waste of oxygen and keep the projects you care about alive, instead of complaining in a corner like some kind of regretful cuck.

@brian6932

Just because you're too much of a mouth breather to comprehend what I said, doesn't mean that the terminology is wrong. Also learn what context is and that the world doesn't revolve around you. My reference to morality was directed to mulverinex hence why I never quoted you specifically dumbass.

How rich that you claim others are "entitled" simply for repeatedly requesting what is obviously an in demand feature yet you started on this path of idiocy crying about receiving what literally amounts to a single email notification twice a month TO A THREAD YOU WILLINGLY SUBSCRIBED TO because the content doesn't align with your pedantic view of "what github should be used for". It's quite evident that your comment regarding temper tantrums was purely projection because the kids on the street don't play the game your way.

With that being said, I also suggest you quit speaking for the devs. All that pandering looks desperate and I'm sure that time could be better allocated to opening one of those pull requests you mention. God forbid the dirty peasants make a request that you don't agree with, how terrible we must be /sarcasm - because I know you aren't smart enough to discern the difference.

MulverineX commented 7 months ago
Unhelpful comment /r/brainrot
Candlemass commented 7 months ago

/r/brainrot

I believe the correct term is "brain damaged" in regards to pedant warrior brian.

anatasiajp commented 3 months ago

I wonder if we could reverse engineering Edge/Kiwi/Yandex to study their source ? Or any opensource to study from ?

Initsnow commented 3 months ago

I wonder if we could reverse engineering Edge/Kiwi/Yandex to study their source ? Or any opensource to study from ?

Kiwi browser is opensource

anatasiajp commented 3 months ago

I wonder if we could reverse engineering Edge/Kiwi/Yandex to study their source ? Or any opensource to study from ?

Kiwi browser is opensource

No it's closed source.

Candlemass commented 3 months ago

Still no extension support?

At what point does a browser become irrelevant due to massive security/privacy concerns in exchange for "speed"?

Users are one malicious redirect ad away from malware infection without the ability to at minimum install adblock filter lists.

anatasiajp commented 3 months ago

https://www.reddit.com/r/androidapps/comments/11vvdlm/kiwi_browser_is_not_open_source_so_stop_calling/

anatasiajp commented 3 months ago

Still no extension support?

At what point does a browser become irrelevant due to massive security/privacy concerns in exchange for "speed"?

Users are one malicious redirect ad away from malware infection without the ability to at minimum install adblock filter lists.

I agree about the needs of having ext,but also disagree with how you make it sounds like easy.

You should know that Kiwi dev spent at least 2000 hours of working nonstop to make it happen.

Initsnow commented 3 months ago

https://www.reddit.com/r/androidapps/comments/11vvdlm/kiwi_browser_is_not_open_source_so_stop_calling/

https://github.com/kiwibrowser/src.next https://github.com/kiwibrowser/src.next/actions/runs/8822657649/job/24221356855

anatasiajp commented 3 months ago

https://www.reddit.com/r/androidapps/comments/11vvdlm/kiwi_browser_is_not_open_source_so_stop_calling/

https://github.com/kiwibrowser/src.next https://github.com/kiwibrowser/src.next/actions/runs/8822657649/job/24221356855

3 years ago lmao

Candlemass commented 3 months ago

@anatasiajp

Still no extension support? At what point does a browser become irrelevant due to massive security/privacy concerns in exchange for "speed"? Users are one malicious redirect ad away from malware infection without the ability to at minimum install adblock filter lists.

I agree about the needs of having ext,but also disagree with how you make it sounds like easy.

You should know that Kiwi dev spent at least 2000 hours of working nonstop to make it happen.

Most of that work has already been done and the code could be lifted from another project which has been referenced MULTIPLE times.... Why do you fail to acknowledge this?

Ducklesss commented 2 months ago

I wonder if we could reverse engineering Edge/Kiwi/Yandex to study their source ? Or any opensource to study from ?

Kiwi browser is opensource

No it's closed source.

Whilst kiwi is closed source, I know for a fact the alternative browser "Mises" is open source, and it has a fully functional intuitive extension system.

MulverineX commented 2 months ago

https://github.com/mises-id/mises-browser-core/blob/main/LICENSE

MPL may be incompatible with BSD

MulverineX commented 2 months ago

lol mises is just a kiwi fork, and it's adware crypto garbage. it's super broken and jank too

gz83 commented 2 months ago

The Android version of Chromium lacks UI design for extension management and related supporting codes. Currently, Google itself and various downstream third-party browsers rarely support extensions on the Android version, except for browsers developed by companies or individuals with strong technical support and money.

At the same time, there have been some third-party browsers that have roughly implemented extension support, such as kiwi, ungoogled-chromium, etc., but these browsers are either no longer updated or the versions are relatively old.

The reason for the current situation of these third-party browsers (which work on Android with extension support) is that the developers who helped them implement extension support seem to be no longer active.

Finally, I know some people may be dissatisfied with my answers or actions, but what I want to say is that this is indeed the fact.

Candlemass commented 2 months ago

lol mises is just a kiwi fork, and it's adware crypto garbage. it's super broken and jank too

All of which is completely irrelevant to the extension support portion of the codebase...

Keep failing to understand this while reaching for any excuse not to implement a basic feature that keeps the browser unusable for many. This is exactly why projects like this meander about in obscurity before dying off.

MulverineX commented 2 months ago

I was just saving other end users the trouble of giving it the time of day, that part wasn't justifying avoiding its code.

Candlemass commented 2 months ago

I was just saving other end users the trouble of giving it the time of day, that part wasn't justifying avoiding its code.

Which serves no purpose in a request thread about extension support....

It's pretty obvious it was referenced as an open source example for those claiming it isn't worth the effort or burying their head in the sand avoiding the fact that forking the code and modifying what's already there invalidates their argument of building the feature from scratch being too cumbersome a task.

Last I checked the thread wasn't about alternatives to TRY and no one suggested that so where you got this from is a mystery and completely removed from the context of the issue.

Ducklesss commented 2 months ago

I was just saving other end users the trouble of giving it the time of day, that part wasn't justifying avoiding its code.

Which serves no purpose in a request thread about extension support....

It's pretty obvious it was referenced as an open source example for those claiming it isn't worth the effort or burying their head in the sand avoiding the fact that forking the code and modifying what's already there invalidates their argument of building the feature from scratch being too cumbersome a task.

Last I checked the thread wasn't about alternatives to TRY and no one suggested that so where you got this from is a mystery and completely removed from the context of the issue.

Thank you for replying to this guy for me and you explained my point very well. I wasn't saying we should use the browser, or that it is worth anything. I was simply giving an example of forked/open source code that showed this sort of thing is possible, and how we could go about it.

anatasiajp commented 2 months ago

@anatasiajp

Still no extension support? At what point does a browser become irrelevant due to massive security/privacy concerns in exchange for "speed"? Users are one malicious redirect ad away from malware infection without the ability to at minimum install adblock filter lists.

I agree about the needs of having ext,but also disagree with how you make it sounds like easy. You should know that Kiwi dev spent at least 2000 hours of working nonstop to make it happen.

Most of that work has already been done and the code could be lifted from another project which has been referenced MULTIPLE times.... Why do you fail to acknowledge this?

It's you, first you say it's opensource and it's so obvious it's not, if a project opened its source code before, then stop providing its source code then it's closed source, because the source is closed, it's only matters if the source code is open or not.

Some people in this place lack this basic knowledge.

Candlemass commented 2 months ago

@anatasiajp

Still no extension support? At what point does a browser become irrelevant due to massive security/privacy concerns in exchange for "speed"? Users are one malicious redirect ad away from malware infection without the ability to at minimum install adblock filter lists.

I agree about the needs of having ext,but also disagree with how you make it sounds like easy. You should know that Kiwi dev spent at least 2000 hours of working nonstop to make it happen.

Most of that work has already been done and the code could be lifted from another project which has been referenced MULTIPLE times.... Why do you fail to acknowledge this?

It's you, first you say it's opensource and it's so obvious it's not, if a project opened its source code before, then stop providing its source code then it's closed source, because the source is closed, it's only matters if the source code is open or not.

Some people in this place lack this basic knowledge.

Are you really this desperate to continue arguing that you're now hinging everything on semantics? He provided an alternative since that is open source. Hint: you labelled it "adware crypto garbage" despte the fact it had nothing to do with anything.

Admit you're wrong and move on already. Continuing to grasp for excuses to white knight for the dev for some illogical reason just looks more snd more pathetic the longer you go on.

anatasiajp commented 2 months ago

Are you really this desperate to continue arguing that you're now hinging everything on semantics? He provided an alternative since that is open source. Hint: you labelled it "adware crypto garbage" despte the fact it had nothing to do with anything.

Are you blind ? Who said that it's "adware crypto garbage" ?

Admit you're wrong and move on already. Continuing to grasp for excuses to white knight for the dev for some illogical reason just looks more snd more pathetic the longer you go on.

How and why do I have to admit ? Kiwi is closed source and that's a fact, the whole open source community would agree with this, Floorp closed its Floorp-components and the whole community treated it as closed source, that's why Kiwi is the same, any small thing become closed source is enough to make your whole project closed source, and Kiwi stopped providing its source code:

KIWI BROWSER IS NOT OPEN SOURCE SO STOP CALLING IT THAT

anatasiajp commented 2 months ago

Also, if you are so desperately want extension supports, create PR and do it yourself first, it's easy said than done.

Be the first one doing something useful. Venting, crying won't help, that's fact, understand ?

Candlemass commented 2 months ago

Are you really this desperate to continue arguing that you're now hinging everything on semantics? He provided an alternative since that is open source. Hint: you labelled it "adware crypto garbage" despte the fact it had nothing to do with anything.

Are you blind ? Who said that it's "adware crypto garbage" ?

Admit you're wrong and move on already. Continuing to grasp for excuses to white knight for the dev for some illogical reason just looks more snd more pathetic the longer you go on.

How and why do I have to admit ? Kiwi is closed source and that's a fact, the whole open source community would agree with this, Floorp closed its Floorp-components and the whole community treated it as closed source, that's why Kiwi is the same, any small thing become closed source is enough to make your whole project closed source, and Kiwi stopped providing its source code:

KIWI BROWSER IS NOT OPEN SOURCE SO STOP CALLING IT THAT

Also, if you are so desperately want extension supports, create PR and do it yourself first, it's easy said than done.

Be the first one doing something useful. Venting, crying won't help, that's fact, understand ?

First of all, I couldn't care less about desktop browsers within the context of this thread. Citing one is irrelevant.

Secondly, the guy was no longer talking about kiwi but rather a fork. You can't even make excuses for the right reference anymore...

The only crying I see taking place here is from you and @MulverineX. The fact that I keep bringing up extension support is to mock how far behind this project is. At the end of the day I am content with IceRaven. All the speed in the world is meaningless without the security and privacy of filter lists. Filter lists also inherently slow a browser down since they have to be quarried for every new page. With that in mind I see nothing special here when the priority of speed comes at the expense of other basic features.

xrishox commented 2 months ago

would love to see support for this. its unfortunate that this thread has derailed into petulant children bickering back and forth.