search

Alex313031 / Thorium-Win-AVX2

Repo to serve AVX2 Windows builds of Thorium. https://github.com/Alex313031/Thorium/
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
362 stars 8 forks source link

Portable THORIUM.BAT fails to launch when there's a space in the path #25

Closed Delphox closed 2 years ago

Delphox commented 2 years ago

image

It's due to the %cd%\BIN\thorium.exe part not being quoted, but just quoting it breaks the command.

I fixed it on my end by changing the start command to START "" "%cd%\BIN\thorium.exe" image

Unless I'm missing something I'm not sure what the original /D "%cd%\BIN\" is for, as the working directory never changes from where the bat is anyway. If it's for just to feed an argument to START so it launches Thorium without keeping a cmd window hostage, then just a "" is the standard for achieving that.

Alex313031 commented 2 years ago

@Delphox Ok thanks, I will change this!

Yeah that is what it was for, so that conhost.exe and cmd.exe dont stay open.

Delphox commented 2 years ago

I see! I was wondering if it had any other purpose. In this case I made a PR in the main repo. 😉