Alex313031 / Thorium-Win

Chromium fork for Windows named after radioactive element No. 90; Windows builds of https://github.com/Alex313031/Thorium
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
1.39k stars 36 forks source link

--disable-machine-id --disable-encryption-win flags doesn't work #26

Closed graphixillusion closed 1 year ago

graphixillusion commented 1 year ago

Hi there.

As the title says i've tried to add this two flags to the batch but when i install some extension and then move everything on a different computer, the extension is gone. How to make this fully portable (with everything, extensions, settings, etc...)? Thank you!

Alex313031 commented 1 year ago

@graphixillusion This is because Thorium doesnt yet have the patches from ungoogled chromium that allow this. The flags are there, but they are ignored in source code.

graphixillusion commented 1 year ago

@Alex313031 thank you for the answer. Is there any eta for this patches to become available in thorium too? Without these two flags is not a real portable app sadly...

Alex313031 commented 1 year ago

@graphixillusion That is strange though. When I use the portable linux or windows version, it will sign me out of sites, and remove all my passwords, but extensions and app settings are preserved.

graphixillusion commented 1 year ago

@Alex313031 i'll try again with the last version then and report it back

graphixillusion commented 1 year ago

@Alex313031 I've just tried the last version but is the same: it keeps the settings but extensions are reset when you move the folder on a different system

Alex313031 commented 1 year ago

@graphixillusion I'm going to add these ungoogled patches to enable truly portable usage

Alex313031 commented 1 year ago

@graphixillusion Added here > https://github.com/Alex313031/thorium/commit/002832e67537bddbe0cdceaafe7986c6ba2238a0

Ive also added these cmdline flags to the thorium.bat for the portable zips, so it should just work out of the box.

Also of note, the --disable-encryption-win was changed to just --disable-encryption in ungoogled chromium

Alex313031 commented 1 year ago

@graphixillusion Is it working for you?

graphixillusion commented 1 year ago

@graphixillusion Is it working for you?

Yep i just tried it and i confirm that it works as it should, thank you