Alex313031 / Thorium-Win

Chromium fork for Windows named after radioactive element No. 90; Windows builds of https://github.com/Alex313031/Thorium
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
1.54k stars 36 forks source link

About release artifact name scheme #278

Open Ra2-IFV opened 1 month ago

Ra2-IFV commented 1 month ago
I'm using scoop, a package manager for Windows, I wrote manifests for Thorium. I enjoy it so much. I'm have problems automating getting recent releases. In previous releases, I obtain version from tag_name, filter it with regex, here's example: key value
tag_name M126.0.6478.231
regex M([\\d.-]+)
version 126.0.6478.231
url https://github.com/Alex313031/Thorium-Win/releases/download/M$version/Thorium_AVX_$version.zip
actual url https://github.com/Alex313031/Thorium-Win/releases/download/M$version/Thorium_AVX_126.0.6478.231.zip

And now, it's, TOTALLY BROKEN because the artifact names becomes so *CENSORED* strange just like thorium_Th24_BETA2_126.0.6478.251.zip just wondering wtf is this why doing this, now there is no easy way to use the autoupdate feature so I have to update version manually I don't know if you would change the pretty random naming rule, like using [Semantic Versioning](https://semver.org/), if not simply close this issue

gz83 commented 1 month ago

I'm not sure why you define this as "wildly"? th24 is our recent work to fix some issues with the cr23 style, and there may continue to be versions marked as th24-beta until we consider th24 to be stable.

If you don't care about some of the issues with the cr23 style, you can completely ignore these th24-beta versions

Ra2-IFV commented 1 month ago

I mean, the release file, naming rule, is wild Doen't follow any naming rules I know so far Also so inconvenient as no other fields matching it in Github API The project is so fucking great, runs blazing fast, no errors, but I'm really not satisfied with the *release file name*.

gz83 commented 1 month ago

If you feel this is not good enough, do you have a better naming scheme for this situation?

Ra2-IFV commented 1 month ago

following previous naming syntax is enough; I also mentioned Semantic Versioning

Ra2-IFV commented 1 month ago

This should be harmless since I'm not asking to change branch or tag names, or the release *title*. If the project is using CI building, it's also a good practice.

gz83 commented 1 month ago

The th24-beta version may still not use the previous naming scheme. As for semantic versioning, I will discuss it with Alex.

gz83 commented 1 month ago

Also, Alex and I don't care about GitHub CI, which doesn't help much for the Thorium project.

https://github.com/Alex313031/thorium/blob/main/docs/FAQ.md

Ra2-IFV commented 1 month ago

Then how do you build releases? in my case CI is really helpful when building things, I can take a break while it's running xD

gz83 commented 1 month ago

The windows version of Thorium is basically compiled by me on my windows or linux machine, without using GitHub CI.

GitHub CI is not really suitable for compiling a large project like Chromium.

Ra2-IFV commented 1 month ago

I'm quite annoyed stucking at old version and drank an overdose of coffee, causing Tachycardia and headache, so very for being emotional and impolite :(

Ra2-IFV commented 1 month ago

Agree. so slow and difficult to solve building errors. Thanks again for creating this project.