Alex313031 / Thorium-Win

Chromium fork for Windows named after radioactive element No. 90; Windows builds of https://github.com/Alex313031/Thorium
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
1.29k stars 33 forks source link

Can't save passwords on M110 zip version, cookies get wiped on exit #35

Closed Delphox closed 1 year ago

Delphox commented 1 year ago

Nothing gets saved...

It also wiped the cookies of the previous installs I had, I assume something changed with the local encryption.

gz83 commented 1 year ago

Nothing gets saved...

It also wiped the cookies of the previous installs I had, I assume something changed with the local encryption.

@Delphox

I think it has something to do with the startup parameter we introduced recently, if it's giving you a bad effect, you can try clearing it before starting the browser

chrome://flags/#disable-encryption

chrome://flags/#disable-machine-id

These two newly added flags are used for portability.

Delphox commented 1 year ago

Yea I removed the Disable Encryption one and I can save passwords again and as well as my cookies survive closing the browser now (its something I noticed after that all my logins were gone). Disable Machine Id is still enabled, I dunno if it has any effect by itself (as in I'd like to be able to transfer the browser between different computers).

gz83 commented 1 year ago

Yea I removed the Disable Encryption one and I can save passwords again and as well as my cookies survive closing the browser now (its something I noticed after that all my logins were gone). Disable Machine Id is still enabled, I dunno if it has any effect by itself (as in I'd like to be able to transfer the browser between different computers).

@Delphox

There are problems with these two startup parameters in the original version of chromium. We recently added two patches to fix these two startup parameters, so that these two parameters can really work and enhance the portability of the browser.

Delphox commented 1 year ago

Ok I tested a fresh install and it seems everything works properly. Seems like this new version just didn't like my old profile, probably due to the mix of encrypted and non-encrypted stuff. I'll try to restart my profile from scratch and see if I notice any other problems, until then I'll close this.

Delphox commented 1 year ago

Alright I can confirm the browser is perfectly portable now after restarting my profile from scratch. I reinstalled all my extensions and logged back into everything I cared about and everything survives, including passwords and cookies which are otherwise lost.

Might be worth adding a warning in the release text that you can't reuse your old profile and trying to open it with the new default arguments will make the passwords and cookies be wiped instantly. It'll at least help people prepare and make a backup of their previous install so they don't get caught offguard like me can move things over at their own pace.