Alex313031 / Thorium-Win

Chromium fork for Windows named after radioactive element No. 90; Windows builds of https://github.com/Alex313031/Thorium
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
1.39k stars 36 forks source link

Sync (Google Sync / Profile Sync) missing on clean portable version (.zip) M111.0.5563.111 WIN64 #43

Closed maxwowpow closed 1 year ago

maxwowpow commented 1 year ago

Used a portable version with flags --disable-encryption --disable-machine-id

In the latest version there is no sync / login function.

On MAC it works (no extra flags)

Vanilla extracted from .zip. Started THORIUM.BAT

Not sure to had seen somewhere, that sync works when encryption enabled? b. On windows no sync possible c. API keys changed or smth?

UPD: There is an avx2 build, so if you've a modern cpu, give that a try: https://github.com/Alex313031/Thorium-AVX2/releases

k3bc999 commented 1 year ago

It looks like the latest version (M111.0.5563.111) does not include Google Sync

gz83 commented 1 year ago

@maxwowpow @k3bc999

Local testing cannot reproduce the problems you are experiencing.

Please try to remove -disable-encryption and -disable-machine-id before trying to use the related features.

maxwowpow commented 1 year ago

without flags and clean run same behavior. Version 111.0.5563.111 (Official Build) (64-bit) @gz83 your version same on win10 64bit?

gz83 commented 1 year ago

@maxwowpow

I'm using Win11 x64, also, this version of Thorium was compiled by me and we have tested it before releasing it. Please try uninstalling the browser and reinstalling it, then try using the sync feature again.

maxwowpow commented 1 year ago

It's about the portable version (Releases / Assets / .zip), not the installable one. Running the cmd THORIUM.BAT

gz83 commented 1 year ago

@maxwowpow

Has the path to the user data folder inside the THORIUM.BAT file been modified?

Also, is it convenient to provide a screenshot of the top right corner of the main interface and a screenshot of the chrome://settings/people page?

maxwowpow commented 1 year ago

The path was not modified: --user-data-dir="%~dp0%\USER_DATA"

image

image

tried a new profile / testing right after unpacking as well. Is there a debug mode / verbose logging switch or similar?

You never know what env vars, reg keys, firewall settings are being checked. There must be some if's in the code to show the sync button.

gz83 commented 1 year ago

@maxwowpow

Sync is available on my end, you can check the other issue I linked to inside this one.

Also, the thorium development team is preparing to update the repo to version M112, and we will investigate this issue during the update process.

k3bc999 commented 1 year ago

I used the installer for a fresh install (M111), but it only exists for local accounts, and there is no button to enable syncing when I click on the user image in the browser. After uninstalling and using the old version (M110), it syncs correctly, but after upgrading from M110 to M111, although the bookmarks and extensions are still there, the account also changes to local It should be noted that the avx2 version of M111 Google Sync is working fine, which is really strange

maxwowpow commented 1 year ago

Confirmed the sync works on the win avx2 build/version. I'm switching to it, because apparently it makes sense if the cpu supports avx2 and as I didn't know about that build, it classifies as an acceptable workaround in my case. Thank you. ps. Feel free to ping me for a 112 test, apart from that, I'll mute the thread. Cheers.

Alex313031 commented 1 year ago

@maxwowpow @k3bc999 Sorry guys, I actually forgot to put the API Keys in for that build. ANyway, the latest builds should have sync working.

However, note that the --disable-encryption seems to break sync because of security reasons. You don't want your google credentials just sitting in a plaintext file.