Alex313031 / thorium-legacy

Repo for Windows XP/Vista & 7/8/8.1 Thorium Builds
https://thorium.rocks/win7
BSD 3-Clause "New" or "Revised" License
237 stars 8 forks source link

Notifications not even trying to appear #50

Open crudebuster opened 9 months ago

crudebuster commented 9 months ago

System Details

Problem Site Notifications are gone. No sign of them whatsoever. Nothing for download, instant messages, emails, only sounds by an extension I use to warn after a successful download.

Additional Notes After I upgraded from M109 to M119 I knew I had to refresh passwords and such but after I did it no notification toasts appear whatsoever... I noticed too late and now the password manager won't save anything since I backtracked and went back to use M109. I hope it's something dumb I did but I'm afraid the thing simply doesn't work because of some dumbassity I did and now I need to redo the god damn profile and account, I guess. P.S.: Problem persists in 122, tested again in 122.0.6261.168, no go.

llExSt commented 7 months ago

Could https://github.com/chromium/chromium/commit/bb92cbcad216a5daf15c87556177ddbd93043692 and possibly https://github.com/chromium/chromium/commit/7a7a41c9d02f786d2a82eb3fe3920c6b29cc2863 be the reason?

crudebuster commented 7 months ago

I suppose so... welp... how do we bring them back then? just revert these?

Alex313031 commented 7 months ago

@crudebuster Both of these were reverted in the M122 version. Are you using that version and the problem still persists?

Does this problem happen in Supermium M122?

crudebuster commented 7 months ago

I've only tried the beta but I'll check it again. @Alex313031 Checked with 122.0.6261.132, not working.

Alex313031 commented 7 months ago

@crudebuster @llExSt I think I know why it is. I recently enabled a change to make notifications less intrusive, but some people want them.

Go to chrome://settings/content/notifications and change it from "Use quieter messaging" to "Sites can ask to send notifications"

crudebuster commented 7 months ago

Done that, the setting was already in, the notification engine seems completely disabled. @Alex313031 P.S.: With Supermium 122 doesn't work too. Tested with "https://www.bennish.net/web-notifications.html". Download notifications changed to bubble with it, but they do appear.

Alex313031 commented 7 months ago

@crudebuster Oof. In that case, this is probably something win32ss will have to fix.

crudebuster commented 4 months ago

In Supermium 124 the notifications work again in Win7 so i'll wait for your update to Thorium.

Nvdtn19 commented 1 month ago

@crudebusterỒ. Trong trường hợp đó, có lẽ win32ss sẽ phải sửa lỗi này.

Do you have plans to update Thorium to match Supermium's version? The notification issues is still not fixed.