search

Alex313031 / thorium-legacy

Repo for Windows XP/Vista & 7/8/8.1 Thorium Builds
https://thorium.rocks/win7
BSD 3-Clause "New" or "Revised" License
198 stars 7 forks source link

Extensions icon unaffected by 'Disable Thorium Top Bar Icons' flag #58

Closed Quisquose closed 3 months ago

Quisquose commented 3 months ago

System Details

Problem The description of the 'Disable 'Thorium Top Bar Icons' flag says: "Disables the custom colored top bar icons in Thorium, and restores the default grey Chromium icon colors".

When this flag is enabled, it successfully makes the all top bar icons grey except for the Extensions icon (which remains blue).

Seeing as the stated purpose of this flag is to restore the default grey icons, it should include the Extensions icon too. It's distracting and looks ugly having this one single icon standing out as the only coloured icon (instead of matching the rest of the theme).

Screenshots Thorium flag

gz83 commented 3 months ago

Currently this flag will not affect the extension icon you pointed out, and we still intend to retain some of the modified icons.

In addition, we will redraw some icons in the future.

Quisquose commented 3 months ago

"we still intend to retain some of the modified icons"

To clarify, I was not asking for the icon to be removed or redrawn, simply for it to be made grey when the flag is enabled. The Extensions icon is grey in Supermium, so presumably this is the normal state of the icon and specific action was taken by Alex to make it blue.

For people who want the coloured icons, they would not enable this flag (which is the Thorium default setting) and the coloured icons would remain.

However, those enabling the flag obviously want grey icons (as per the flag's description) but this is currently inconsistent because it is only partially implemented.

gz83 commented 3 months ago

"we still intend to retain some of the modified icons"

To clarify, I was not asking for the icon to be removed or redrawn, simply for it to be made grey when the flag is enabled. The Extensions icon is grey in Supermium, so presumably this is the normal state of the icon and specific action was taken by Alex to make it blue.

For people who want the coloured icons, they would not enable this flag (which is the Thorium default setting) and the coloured icons would remain.

However, those enabling the flag obviously want grey icons (as per the flag's description) but this is currently inconsistent because it is only partially implemented.

What I said earlier about redrawing the icon is that we are working on our side, not that you are asking us to redraw the icon.

At the same time, it is intentional that some icons currently remain in Thorium style.

Alex313031 commented 3 months ago

@gz83 @Alex313031 Yeah, but with CR23 (the 2023 UI refresh google is pushing), I will add this icon to the list of ones reverted back to grey with this flag.

Lemvo commented 1 month ago

Hi @Alex313031 seeing as you are now going to provide the option to revert the Extension icon back to its default gray color (as part of 2023 UI refresh that you spoke of above) will there also be the option to revert the blue sub-menu arrow/triangles back to the standard gray color too?

I love Thorium and its features (especially the Win7 compatibility) but I really want the kind of consistent uniform appearance that you get in most other browsers, rather than having bits of the menu in a different color (which I find visually jarring and distracting).

Of course if anyone likes the blue sub-menu triangles then they should be allowed to keep their preference, but it's pretty non-standard. I've never seen any other chromium derivative do this to its menus, so I'm sure that having the option to revert menu elements back to their familiar standardized default gray color would be appreciated by many people.

Thanks!