search

Alex313031 / thorium-legacy

Repo for Windows XP/Vista & 7/8/8.1 Thorium Builds
https://thorium.rocks/win7
BSD 3-Clause "New" or "Revised" License
223 stars 8 forks source link

Side by Side Error Recorded in Windows XP #85

Closed DaveH1 closed 4 months ago

DaveH1 commented 4 months ago

Windows XP SP3 32 bit Thorium Legacy 122.0.6261.169.

I am seeing multiple errors in my Windows XP System log every time I run Thorium. They are apparently coming from a Google AI thing which has been installed.

Clipboard-2

Clipboard-1

This is something which is presumably not compatible with XP, and if so it should be removed in versions of Thorium targetting XP. I have worked around the problem by re-naming chrome_screen_ai.dll, but this is obviously not an ideal solution. Thanks, Dave.

Alex313031 commented 4 months ago

@DaveH1 I cant reproduce, I can't even find this .dll in my user data folder.

Did you enable translation, screen auto translation, or any feature like that.

EDIT: Also seems to have to do with optical character recognition when editing or translation PDFs.

Alex313031 commented 4 months ago

@DaveH1 OK I was able to re-create. This .dll is not included in Thorium, but rather is downloaded as needed via the components updater (other examples can be seen on chrome://components). It is only downloaded when doing one of the tasks mentioned above. Some .exe or .dll's have a .manifest file named after them side by side in the directory they are in. But the .manifest can also be compiled into the binary (which is what this .dll has done). The .manifest file describes file attributes, including the Visual C version used to make it, and its capabilities. The manifest Google included in this binary contains capability attributes that XP doesn't recognize, as XP lacks them. This isn't of concern, and the .dll still seems to load properly. This bug should also occur in Supermium too for the same reason.

There isn't really a way to fix the warnings though, since this is downloaded from Google when OCR or Translation is used, and the source code isn't available.

UPDATE: Yup, I can confirm this bug occurs in Thorium and Supermium, both M121 and M122. It is out of our hands.

DaveH1 commented 4 months ago

Thanks Alex. Sorry yes, I should of course have mentioned that the Screen_AI folder was not there when I first installed Thorium, but appeared later. That now makes perfect sense. I did use the translate function, with must have triggered it to download. I guess translate won't work without it, so I guess I will just have to suppress the error messages by renaming the DLL so it doesn't load every time the browser starts, which is what I have been doing, and remember to do it again after every time I use the translate function! Thanks, Dave.

Alex313031 commented 4 months ago

@DaveH1 Yeah, disabling this at the source code level would cause more problems than it is worth, just to get rid of a warning message. Closing now.

DaveH1 commented 4 months ago

Thanks Alex. Following a suggestion on MSFN, I'm now using the --disable-component-update startup flag, which has removed the problem. Google Translate still works, so it's all good. Cheers, Dave.