Alex313031 / thorium-libjxl

libjxl for Chromium - restores JPEG-XL functionality to Thorium/Chromium post M109
https://github.com/Alex313031/thorium-libjxl
BSD 3-Clause "New" or "Revised" License
37 stars 4 forks source link

Sample HDR image looks too bright in Thorium v117 #18

Closed o-l-a-v closed 1 month ago

o-l-a-v commented 10 months ago

Here's an image that looks too bright in Thorium v117.0.5938.157 (Official Build) (64-bit):

Found here:

Here's a screenshot:

231120 - Cat HDR in GIMP Paint NET XnView MP IrfanView Thorium

Alex313031 commented 9 months ago

@o-l-a-v Might just need to update the libjxl library, see > https://github.com/Alex313031/thorium-libjxl/issues/19

Alex313031 commented 8 months ago

@o-l-a-v I updated it to 0.9.0 in the M120 version. Can you test?

o-l-a-v commented 8 months ago

@o-l-a-v I updated it to 0.9.0 in the M120 version. Can you test?

Thanks, will test tomorrow if I remember it. :)

o-l-a-v commented 8 months ago

@Alex313031

Thorium still struggles with this image. Thorium v120.0.6099.235 AVX2 to the right, GIMP to the left.

image
Alex313031 commented 8 months ago

@o-l-a-v Nothing more I can do, as I cannot update the libjxl library past 0.9.0. They removed some stuff that it critical for integrating into blink in 0.9.1. Im sorry.

Traneptora commented 8 months ago

What was removed that was critical for integrating into blink?

gz83 commented 8 months ago

What was removed that was critical for integrating into blink?

https://github.com/libjxl/libjxl/commit/b08a704978d5aeaf6fd1e2aee3ae5907a89e1f96

The deleted things are here. We modified the code based on the patches provided by Google engineers, and the version numbers are consistent with those used by Google engineers.

@Traneptora

Traneptora commented 8 months ago

How are any of those things critical? Most of them are encoder settings, except for JxlDecoderGetDefaultPixelForamt which is noncritical (you either request an image in the pixel format you need, you look at the bit depth tag in the header if you want to use the image's tagged format).

Alex313031 commented 7 months ago

@Traneptora @o-l-a-v @gz83 We fixed it, as they fixed it upstream. Now we are using libhighway 1.0.7, and libjxl 0.9.2.

Alex313031 commented 7 months ago

@o-l-a-v @Traneptora Can you try the M121 version and report back

o-l-a-v commented 7 months ago

@Alex313031

They still don't look the same.

Screenshot 2024-02-20 160838

gz83 commented 7 months ago

0.9.2 is the latest publicly released version. If you still cannot get the expected results, there may be other factors affecting it.

@o-l-a-v

o-l-a-v commented 7 months ago

0.9.2 is the latest publicly released version. If you still cannot get the expected results, there may be other factors affecting it.

@o-l-a-v

Sure, but that's out of my knowledge.

Thorium devs say "We fixed it, as they fixed it upstream." without even trying the test image in this issue original post apperently. I just report that: No, the problem still persists.

Maybe @Traneptora or JXL devs have more knowledge about what causes this.

Alex313031 commented 7 months ago

@o-l-a-v Dang, I'm sorry. No I didn't test, I just assumed it would fix it since 0.9.1 (and hence 0.9.2), is supposed to fix HDR issues.

o-l-a-v commented 7 months ago

No worries @Alex313031, I also understand that this could be out of your/Thorium's control. :)