search

Alex313031 / thorium-libjxl

libjxl for Chromium - restores JPEG-XL functionality to Thorium/Chromium post M109
https://github.com/Alex313031/thorium-libjxl
BSD 3-Clause "New" or "Revised" License
37 stars 4 forks source link

Remove expiry or set it to -1 #3

Closed goodusername123 closed 1 year ago

goodusername123 commented 1 year ago

Currently it's set so JPEG-XL expires once M115 is reached however this should be removed or set to -1 (-1 means it will never expire). I am more in favor of just removing the expiry stuff as doing so would reduce the total complexity of the patch slightly. I think it's all within "flag-metadata.json" but I don't know chromium that well so the expiry stuff might be connected somewhere else but probably not.

gz83 commented 1 year ago

Currently it's set so JPEG-XL expires once M115 is reached however this should be removed or set to -1 (-1 means it will never expire). I am more in favor of just removing the expiry stuff as doing so would reduce the total complexity of the patch slightly. I think it's all within "flag-metadata.json" but I don't know chromium that well so the expiry stuff might be connected somewhere else but probably not.

@goodusername123

I think that expired milestone is just a marker, it will not cause the flag itself to expire or become invalid. However, setting it to -1 may also be a worthwhile job.

Alex313031 commented 1 year ago

@gz83 @goodusername123 That is indeed where Milestone/Version expiration is set. It does not remove the flag when the milestone is newer than the value, but rather sets it behind a flag that's named something like "Temporarily unexpire M109 flags.". I am aware that this is in there, but I intentionally kept it in there. Because I don't know the long term future of jpeg xl in thorium. By the time M115 rolls around, they may have made a breaking change that makes it where I cant reintegrate libjxl.

However, it does no harm to set it to never expire, so here > https://github.com/Alex313031/thorium-libjxl/commit/5fb1bdcceed45f477739525b435f795cf6fdbb3a

Alex313031 commented 1 year ago

@gz83 Oops i Just saw your pull request. Can you restore the flag metadata file, so that I can merge your request. Since I just changed it myself therefore there would be a file conflict.

gz83 commented 1 year ago

@gz83 Oops i Just saw your pull request. Can you restore the flag metadata file, so that I can merge your request. Since I just changed it myself therefore there would be a file conflict.

@Alex313031

ok I have restored the metadata file, now only the .patch file is left, please review

Alex313031 commented 1 year ago

@gz83 @goodusername123 @jonsneyers Merged > https://github.com/Alex313031/thorium-libjxl/commit/e28fcb0edf41ced6ba2ffa810cad4c8dddc57495