search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
4.62k stars 142 forks source link

Feature request: Add vertical tabs support #141

Open user858753257 opened 1 year ago

user858753257 commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like, including relevant patches or source

MS edge and Vivaldi have the feature of displaying tabs vertically .

Could also be implemented as a plug-in where there is no patch already

gz83 commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like, including relevant patches or source

MS edge and Vivaldi have the feature of displaying tabs vertically .

Could also be implemented as a plug-in where there is no patch already

@F3000

Vertical tabs seem to require a significant change to the interface logic, and I don't think it should be introduced in Thorium.

Alex313031 commented 1 year ago

@gz83 @F3000 It would be cool to add this as a flag. However, unlike WebUI, this would have to be implemented in native views, with seperate code for each platform. It would require a significant reworking of the code. Also, I am too dumb to know how to do something like that lol. I would be happy to try it out if there was a patch available, but currently, the only browsers that have this feature are closed source, and it took them many months or years to build it with a whole team of developers (Im talking about naver whale, vivaldi, edge). I just don't think it would be feasible to do unless someone can provide me a source code or .patch that I could rework into the Thorium source.

thorrrr commented 10 months ago

@gz83 @F3000 It would be cool to add this as a flag. However, unlike WebUI, this would have to be implemented in native views, with seperate code for each platform. It would require a significant reworking of the code. Also, I am too dumb to know how to do something like that lol. I would be happy to try it out if there was a patch available, but currently, the only browsers that have this feature are closed source, and it took them many months or years to build it with a whole team of developers (Im talking about naver whale, vivaldi, edge). I just don't think it would be feasible to do unless someone can provide me a source code or .patch that I could rework into the Thorium source.

HI Alex Brave have just introduced Vertical Tabs so not sure if that would help. Would be really great if you could add this functionality as most browsers are adding this.

heyitsazar commented 10 months ago

Hey @Alex313031. Thanks for this great project! As @thorrrr mentioned this feature is already included in Brave. If I'm not mistaken their code is open, maybe this can help you to add it to Thorium in the future. Vertical tab lovers are waiting for it!

gz83 commented 10 months ago

Thank you for your advice.

zodman commented 3 days ago

same as https://github.com/Alex313031/thorium/issues/419