search

Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
4.67k stars 145 forks source link

Additional apt dependency #4

Closed midzer closed 2 years ago

midzer commented 2 years ago

Hi Alex,

great project first of all! :+1:

After installation of release .deb file via dpkg -i I wonder why there is an thorium-browser-unstable.list file in my /etc/apt/sources.list.d/ now containing:

deb [arch=amd64] https://dl.google.com/linux/chrome/deb/ stable main

Currenty, I have Chrome stable from official sources installed. So there is a conflict now. Why Thorium needs this additional apt dependency?

Have a nice week midzer

Alex313031 commented 2 years ago

@midzer It doesn't, this is a stupid quirk in the chromium source code. I am going to release a patch soon. It is perfectly safe to delete this. Thanks for the bug reports and using my project!!

Alex313031 commented 2 years ago

@midzer This is now fixed in the latest release. It is the regular release though, so I will make an AVX only again for you. It would be good to sudo apt purge thorium-browser-unstable before installing this next one, to make sure no stale files are left behind. Once you respond I will be closing this issue.

midzer commented 2 years ago

Thanks for your effort, @Alex313031 :+1:

But you don't have to release an AVX only (extra for me) so often. Current release is fine for me :)

Let's keep the project growing and spread the word.

Alex313031 commented 2 years ago

Well I cant promise any frequency, but when me and my machine arent doing anything intensive (im just watching youtube), I just set the jobs to 7 to leave one core for my use. I just let it compile in the background so its really no big deal and I want everyone that uses thorium to have the latest stuff. If its just a minor version increase I might not make an AVX only build, but this one has upstream patches and has the changes outlined here https://github.com/Alex313031/Thorium/releases/tag/M98.0.4757.0 and I'm not busy so it's no trouble at all. Im building it right now as we speak and will update you here when it's done. Also, building it anyway is good because I got some users of Thorium-Special that need AVX only (like you) and one that needs SSE4.2 only, and I also post SSE4 builds that I use on my old laptop, and Vishera builds that I use on my machine (Piledriver, i.e. Vishera, i.e. 2nd Gen bulldozer)

Also, did you read my thing about chromiumos i posted on your other issue?

midzer commented 2 years ago

Okay, just do how you like for release. I am plenty of happy already, because chromium is not maintained in debian any more...

For chromium, I've openen an issue there, see https://github.com/Alex313031/ChromiumOS/issues/2

Alex313031 commented 2 years ago

I KNOW. SO FUCKING SAD. Im seriously considering contacting the www package section maintainers and chromium maintainers for Debian and offer to continue building for them.

Alex313031 commented 2 years ago

@midzer Also the chromiumos thing is an issue with etcher not chromiumos, I noticed this too. Please use https://github.com/balena-io/etcher/releases/tag/v1.5.122 Bug is mentioned here > https://github.com/balena-io/etcher/issues/3648

midzer commented 2 years ago

I just tried latest release and this is fixed now. Awesome!

Alex313031 commented 2 years ago

@midzer Wait are you talking about chromiumos or thorium?

midzer commented 2 years ago

Thorium, we're in Thorium repo here :)

Alex313031 commented 2 years ago

@midzer Going to close this now.