Alex313031 / thorium

Chromium fork named after radioactive element No. 90. Windows and MacOS/Raspi/Android/Special builds are in different repositories, links are towards the top of the README.md.
https://thorium.rocks/
BSD 3-Clause "New" or "Revised" License
4.7k stars 146 forks source link

Ability to change Min and Max Tab width like in Firefox #548

Open Kol9yN opened 7 months ago

Kol9yN commented 7 months ago

1 reason why I HATE all Chromium based browsers its tab width, look at this when you have more then 20 tabs opened, it becomes a tabs fence! So painful! :(

TabsFence

Please add params based like in FireFox, so u can set tab width browser.tabs.tabClipWidth 140 browser.tabs.tabMinWidth 140 is optimal values

Fix it please if its possible.

Kol9yN commented 2 weeks ago

@gz83 already added in coming updates? :)

gz83 commented 2 weeks ago

This is a batch closing operation (can also be regarded as a ping), I will reopen the issues that still have new responses

Alex313031 commented 2 weeks ago

@Kol9yN No promises, but see below, we could possibly add this.

@gz83 I already saw in the source code where the initial tab size is a const size_t of 50 (which I assume means 50 pixels).

It may be possible to add a flag similar to the NTP flag, which would add a text box for the user to add a custom tab width. It may be better to add a list of pre-made values, so that they don't accidentally add a really low or really high number and make the browser unusable.

Kol9yN commented 2 weeks ago

Ugly Tab size is first reason why i stopped using any Chrome based browsers, but i like Thorium, and want to use it. If possible to add horizontal scroll buttons on left and right of tab bar, it will be great! have a fields with min and max size is great, but please no hardcoded limits here, cuz depends of screen size and resolution, each user can set own width

Alex313031 commented 6 days ago

@Kol9yN Did it! > https://github.com/Alex313031/thorium/commit/82d84cc52e3231fc0173b7e446cf4eb2c537079f

Beta 2 Windows build has this > https://github.com/Alex313031/Thorium-Win/releases/tag/M126.0.6478.251-1 . For Linux you will have to wait until the next release (which will be stable, not beta).

Kol9yN commented 4 days ago

@Alex313031 Problem still not solved, tabs still shrinking :( shrinkedtabs

I turned on 2 flags as you recommend in release note flagsettings

May we misunderstood, i mean set a MINIMAL tab width изображение Here no sense how many tabs i open, it always keep minimal width to 140px, and if tabs MORE then can fit in ribbon, here appears horizontal scroll arrows, so you can scroll left\right for switch to tab what is out of vision on ribbon

Do you have Firefox installed on your PC? Can you launch and look on it by self? Open 20+ new tabs in FF and you will see what i mean

Kol9yN commented 4 days ago

ROFL!!! I found a fix, this flag called Tab scrolling, and disabled by default... chrome://flags/#scrollable-tabstrip

Scrollable-tab-strip

Maybe have sense to enable it by default with some option on your taste? :)

Here official ticket about it on Chromium dev pages https://issues.chromium.org/issues/40077123

Kol9yN commented 4 days ago

Here poped another UI inconvenience, tabs ribbon not have smooth scrolling :( i tried to found in Google if possible to enable it, but no way, may somewhere under the hood this option can be enabled?

Kol9yN commented 4 days ago

Got another bug based with it, looks like some css styles conflicting with scrollable ribbon and new feature of tab width

изображение

On last tab always appearing box and covering X(close) button

Here current flag settings for try to reproduce изображение

gz83 commented 4 days ago

What system are you currently using? If it is a non-Linux system, then this feature will not be enabled by default (Google does not enable this feature by default for non-Linux systems), and third-party developers need to manually enable it in the code.

This feature is non-standard on non-Linux systems, according to a senior Google engineer.

@Kol9yN

gz83 commented 4 days ago

In addition, Tab scrolling has caused a lot of crashes in the past (due to exceeding the border). I don't know if the problem of exceeding the border has been fixed. Please use it with caution.

@Kol9yN

gz83 commented 4 days ago

One more piece of information: the effect of the Tab scrolling function on Linux is not exactly the same as the flag you set.

@Kol9yN

Kol9yN commented 4 days ago

Win11

Kol9yN commented 4 days ago

Addition: Box-cover of X appears if scrollable ribbon disabled!

Alex313031 commented 3 days ago

@Kol9yN Oh ok. Yeah, @gz83 the tab scrolling flag is what he was looking for. The overflow bug might be something to do with Th24 (unless it also happens with the regular CR23 UI). Can you test on Windows, by enabling that flag and the "tab scrolling buttons" flag.

Kol9yN commented 3 days ago

About overflow bug, my case on Win11, not sure about Linux Distros, need someone to test it

gz83 commented 3 days ago

@Kol9yN Oh ok. Yeah, @gz83 the tab scrolling flag is what he was looking for. The overflow bug might be something to do with Th24 (unless it also happens with the regular CR23 UI). Can you test on Windows, by enabling that flag and the "tab scrolling buttons" flag.

This feature does not seem to cause crashes for the time being

@Alex313031

Kol9yN commented 2 days ago

I tested scrollable ribbon on Win 10 and 11, on different 10 PC's and all works good for now, except overlap box ;)